<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21192">View Revision</a></tr></table><br /><div><div><p>I'm afraid your patch does not apply for me:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="console" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #000080">$ arc patch D21192</span>
<span style="color: #808080"> INFO Base commit is not in local repository; trying to fetch.</span>
<span style="color: #808080">Created and checked out branch arcpatch-D21192.</span>
<span style="color: #808080">Checking patch lookandfeel/contents/lockscreen/MainBlock.qml...</span>
<span style="color: #808080">error: while searching for:</span>
<span style="color: #808080"> focus: true</span>
<span style="color: #808080"> echoMode: TextInput.Password</span>
<span style="color: #808080"> inputMethodHints: Qt.ImhHiddenText | Qt.ImhSensitiveData | Qt.ImhNoAutoUppercase | Qt.ImhNoPredictiveText</span>
<span style="color: #808080"> enabled: !authenticator.graceLocked</span>
<span style="color: #808080"> revealPasswordButtonShown: true</span>
<span style="color: #808080"></span>
<span style="color: #808080"> onAccepted: {</span>
<span style="color: #808080"></span>
<span style="color: #808080">error: patch failed: lookandfeel/contents/lockscreen/MainBlock.qml:59</span>
<span style="color: #808080">error: while searching for:</span>
<span style="color: #808080"> PlasmaComponents.Button {</span>
<span style="color: #808080"> id: loginButton</span>
<span style="color: #808080"> Layout.fillWidth: true</span>
<span style="color: #808080"></span>
<span style="color: #808080"> text: i18nd("plasma_lookandfeel_org.kde.lookandfeel", "Unlock")</span>
<span style="color: #808080"> onClicked: startLogin()</span>
<span style="color: #808080"></span>
<span style="color: #808080">error: patch failed: lookandfeel/contents/lockscreen/MainBlock.qml:93</span>
<span style="color: #808080">Checking patch lookandfeel/contents/lockscreen/LockScreenUi.qml...</span>
<span style="color: #808080">Hunk #1 succeeded at 40 (offset 4 lines).</span>
<span style="color: #808080">Applying patch lookandfeel/contents/lockscreen/MainBlock.qml with 2 rejects...</span>
<span style="color: #808080">Rejected hunk #1.</span>
<span style="color: #808080">Rejected hunk #2.</span>
<span style="color: #808080">Applied patch lookandfeel/contents/lockscreen/LockScreenUi.qml cleanly.</span>
<span style="color: #808080"></span>
<span style="color: #808080"> Patch Failed! </span>
<span style="color: #808080">Usage Exception: Unable to apply patch!</span></pre></div>
<p>Did you work against git master, or the version that was on your machine? If the latter, you need to work on git master if you're going to submit a patch that will be applied against git master. :)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21192">https://phabricator.kde.org/D21192</a></div></div><br /><div><strong>To: </strong>siddharthasahu, ngraham, Plasma, VDG<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>