<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20612">View Revision</a></tr></table><br /><div><div><p>+1</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20612#inline-115865">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ConfigGeneral.qml:44</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">Layout.minimumWidth:</span> <span style="color: #004012">previewFrame</span><span class="p">.</span><span style="color: #004012">width</span> <span style="color: #aa2211">+</span> <span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">smallSpacing</span> <span style="color: #aa2211">*</span> <span style="color: #601200">2</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">Layout.maximumWidth:</span> <span style="color: #004012">Layout</span><span class="p">.</span><span style="color: #004012">minimumWidth</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">Layout.minimumHeight:</span> <span style="color: #004012">previewFrame</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">+</span> <span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">smallSpacing</span> <span style="color: #aa2211">*</span> <span style="color: #601200">2</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Did you try <tt style="background: #ebebeb; font-size: 13px;">Layout.preferredHeight</tt>?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20612#inline-115866">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ConfigGeneral.qml:53</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #74777d"><span class="bright">// just to provide some visual feedback, cannot have checked without checkable enabled</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">checkable:</span> <span style="color: #000a65">true</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">onClicked:</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">checked</span> <span style="color: #aa2211">=</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">binding</span><span class="p">(</span><span style="color: #aa4000">function</span><span class="p">()</span> <span class="p">{</span> <span style="color: #74777d">// never actually allow it being checked</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">return</span> <span style="color: #004012">iconMenu</span><span class="p">.</span><span style="color: #004012">status</span> <span style="color: #aa2211">===</span> <span style="color: #004012">PlasmaComponents</span><span class="p">.</span><span style="color: #004012">DialogStatus</span><span class="p">.</span><span style="color: #004012">Open</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">})</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">iconMenu</span><span class="p">.</span><span style="color: #004012">open</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">,</span> <span style="color: #004012">height</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">onClicked:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">iconMenu</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">opened</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">iconMenu</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">close</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">iconMenu</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">open</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I was wondering, while at it, can we make the menu open <tt style="background: #ebebeb; font-size: 13px;">onPressed</tt> to be consistent with all other menus and buttons with menus?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20612">https://phabricator.kde.org/D20612</a></div></div><br /><div><strong>To: </strong>ngraham, Plasma, VDG<br /><strong>Cc: </strong>broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>