<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20549">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20549#inline-115912">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcm.cpp:88</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_newStuffDialog</span><span style="color: #aa2211">-></span><span class="n">winId</span><span class="p">();</span> <span style="color: #74777d">// so it creates the windowHandle();</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">connect</span><span class="p">(</span><span class="n">m_newStuffDialog</span><span class="p">.</span><span class="n">data</span><span class="p">(),</span> <span style="color: #aa2211">&</span><span class="n">KNS3</span><span style="color: #aa2211">::</span><span class="n">DownloadDialog</span><span style="color: #aa2211">::</span><span class="n">accepted</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">KCMPlymouth</span><span style="color: #aa2211">::</span><span class="n">load</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">connect</span><span class="p">(</span><span class="n">m_newStuffDialog</span><span class="p">.</span><span class="n">data</span><span class="p">(),</span> <span style="color: #aa2211">&</span><span class="n">KNS3</span><span style="color: #aa2211">::</span><span class="n">DownloadDialog</span><span style="color: #aa2211">::</span><span class="n">finished</span><span class="p">,</span> <span class="n">m_newStuffDialog</span><span class="p">.</span><span class="n">data</span><span class="p">(),</span> <span style="color: #aa2211">&</span><span class="n">KNS3</span><span style="color: #aa2211">::</span><span class="n">DownloadDialog</span><span style="color: #aa2211">::</span><span class="n">deleteLater</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Ideally here we would reload the model and then set the newly installed theme as current</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20549#inline-115911">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcm.cpp:157</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">for</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"> </span><span class="n"><span class="bright">i</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span><span class="bright"> </span><span class="n"><span class="bright">i</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"> </span><span class="n"><span class="bright">list</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">size</span></span><span class="bright"></span><span class="p"><span class="bright">();</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">++</span></span><span class="bright"></span><span class="n"><span class="bright">i</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"> </span> <span class="n">QFileInfo</span> <span class="n">fileInfo</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">=</span></span> <span class="n">list<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">at</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">i</span></span><span class="bright"></span><span class="p"><span class="bright">);</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="n"><span class="bright">QStandardItem</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span class="n"><span class="bright">row</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">new</span></span><span class="bright"> </span><span class="n"><span class="bright">QStandardItem</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">fileInfo</span><span class="p">.</span><span class="n">fileName</span><span class="p">(<span class="bright">)</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">row</span><span style="color: #aa2211">-></span><span class="n">setData</span><span class="p">(</span><span class="n">fileInfo</span><span class="p">.</span><span class="n">fileName</span><span class="p">(),</span> <span class="n">PluginNameRole</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">row</span><span style="color: #aa2211">-></span><span class="n">setData</span><span class="p">(</span><span class="n">installedCg</span><span class="p">.</span><span class="n">entryMap</span><span class="p">().</span><span class="n">contains</span><span class="p">(</span><span class="n">fileInfo</span><span class="p">.</span><span class="n">fileName</span><span class="p">()),</span> <span class="n">UninstallableRole</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">auto</span></span><span class="bright"> </span><span class="n"><span class="bright">list</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">dir</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">entryInfoList</span></span><span class="bright"></span><span class="p"><span class="bright">();</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">for</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span> <span class="n">QFileInfo</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">&</span></span><span style="color: #a0a000">fileInfo</span> <span class="bright"></span><span class="p"><span class="bright">:</span></span> <span class="n">list<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n"><span class="bright">QString</span></span><span class="bright"> </span><span class="n"><span class="bright">pluginName</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n">fileInfo</span><span class="p">.</span><span class="n">fileName</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think the model population must be split from the KCM <tt style="background: #ebebeb; font-size: 13px;">load()</tt> so you can reload the model without marking it as non-dirty.</p>
<p style="padding: 0; margin: 8px;">Right now when installing a new theme, the Apply button doesn't enable and no theme is selected. Ideally it would select the newly installed theme.</p>
<p style="padding: 0; margin: 8px;">Also needs a <tt style="background: #ebebeb; font-size: 13px;">emit selectedPluginIndexChanged();</tt> after reloading the model as a model reset will cause <tt style="background: #ebebeb; font-size: 13px;">ListView</tt> to forget its <tt style="background: #ebebeb; font-size: 13px;">currentIndex</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20549#inline-115916">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcm.cpp:210</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">rc</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="n"><span class="bright">K</span>Message<span class="bright">Box</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">error</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">nullptr</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Unable to authenticate/execute the action: %1<span class="bright">, %2</span>"</span><span class="p">,</span> <span class="n">job</span><span style="color: #aa2211">-></span><span class="n">error</span><span class="p">(),</span> <span class="n">job</span><span style="color: #aa2211">-></span><span class="n">errorString</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span class="n"><span class="bright">emit</span></span><span class="bright"> </span><span class="n"><span class="bright">showError</span>Message<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Unable to authenticate/execute the action: %1<span class="bright"> (%2)</span>"</span><span class="p">,</span> <span class="n">job</span><span style="color: #aa2211">-></span><span class="n">error</span><span class="p">(),</span> <span class="n">job</span><span style="color: #aa2211">-></span><span class="n">errorString</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">emit</span> <span style="color: #004012">load</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">In error handling we should probably check for <tt style="background: #ebebeb; font-size: 13px;">error() == KAuth::ActionReply::UserCancelledError</tt> to not show a pointless error message when user canceled</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20549#inline-115915">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcm.cpp:211</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="n"><span class="bright">K</span>Message<span class="bright">Box</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">error</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">nullptr</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Unable to authenticate/execute the action: %1<span class="bright">, %2</span>"</span><span class="p">,</span> <span class="n">job</span><span style="color: #aa2211">-></span><span class="n">error</span><span class="p">(),</span> <span class="n">job</span><span style="color: #aa2211">-></span><span class="n">errorString</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span class="n"><span class="bright">emit</span></span><span class="bright"> </span><span class="n"><span class="bright">showError</span>Message<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Unable to authenticate/execute the action: %1<span class="bright"> (%2)</span>"</span><span class="p">,</span> <span class="n">job</span><span style="color: #aa2211">-></span><span class="n">error</span><span class="p">(),</span> <span class="n">job</span><span style="color: #aa2211">-></span><span class="n">errorString</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">emit</span> <span style="color: #004012">load</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This isn't a signal, also why do you need to reload when saving? It's not like any themes could magically appear here?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20549#inline-115910">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcm.h:72</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">beginSave</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">finishSave</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think this should be a property <tt style="background: #ebebeb; font-size: 13px;">Q_PROPERTY(bool saving...)</tt> or more generic <tt style="background: #ebebeb; font-size: 13px;">busy</tt> like in the other KCMs and then proper bindings in the UI</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20549#inline-115913">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:68</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">Kirigami</span><span class="p">.</span><span style="color: #004012">InlineMessage</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">id: infoLabel</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">In all the other KCMs the <tt style="background: #ebebeb; font-size: 13px;">InlineMessage</tt> is above the controls to not push them around as it comes and goes</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20549#inline-115914">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:74</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"> </span><span style="color: #004012"><span class="bright">RowLayout</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"> </span><span style="color: #004012"><span class="bright">Item</span></span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #004012"><span class="bright">QtControls</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">ProgressBar</span></span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">id: progressBar</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't think this "progress" bar adds much value</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R258 Plymouth KCM</div></div></div><br /><div><strong>BRANCH</strong><div><div>improve-the-look-of-the-plymouth-boot-splash-screen-kcm-ui (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20549">https://phabricator.kde.org/D20549</a></div></div><br /><div><strong>To: </strong>GB_2, Plasma, VDG, ngraham, broulik<br /><strong>Cc: </strong>abetts, ngraham, broulik, VDG, plasma-devel, Plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart<br /></div>