<table><tr><td style="">broulik updated this revision to Diff 56056.<br />broulik edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-mqnxq5eiefv7kov/">(Show Details)</a><br />broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20265">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">
<li class="remarkup-list-item">Address review comments</li>
<li class="remarkup-list-item">Rewrite job handling to be kuiserver and kill it</li>
</ul>

<p>I removed the dataengine rewrite from the diff to make it a bit less overwhelming, will come up as separate patch<br />
kuiserver removal is also not in the diff as that's just deleting the folder and removing it from CMakeLists</p></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>* **Server**: This class handles the DBus stuff and acts as a dumb proxy between DBus and the consumer, e.g. the `NotificationModel` or the old dataengine.<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"><br />
<br />
The old dataengine is wired up to the new `Server` for compatibility. The grouping stuff in there has been dropped, the old plasmoid should otherwise continue to work as normal. The dataengine inhibition feature used by plasma-nm is defunct now, not sure how this could be implemented in the new system as the `Server` knows nothing about inhibitions, it's all filtered in the models.</span></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D20265?vs=55470&id=56056">https://phabricator.kde.org/D20265?vs=55470&id=56056</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20265">https://phabricator.kde.org/D20265</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>libnotificationmanager/CMakeLists.txt<br />
libnotificationmanager/LibNotificationManagerConfig.cmake.in<br />
libnotificationmanager/autotests/CMakeLists.txt<br />
libnotificationmanager/autotests/notifications_test.cpp<br />
libnotificationmanager/dbus/org.freedesktop.Notifications.xml<br />
libnotificationmanager/dbus/org.kde.JobViewServer.xml<br />
libnotificationmanager/dbus/org.kde.JobViewServerV2.xml<br />
libnotificationmanager/dbus/org.kde.JobViewV2.xml<br />
libnotificationmanager/dbus/org.kde.JobViewV3.xml<br />
libnotificationmanager/dbus/org.kde.kuiserver.xml<br />
libnotificationmanager/declarative/CMakeLists.txt<br />
libnotificationmanager/declarative/notificationmanagerplugin.cpp<br />
libnotificationmanager/declarative/notificationmanagerplugin.h<br />
libnotificationmanager/declarative/qmldir<br />
libnotificationmanager/job.cpp<br />
libnotificationmanager/job.h<br />
libnotificationmanager/job_p.cpp<br />
libnotificationmanager/job_p.h<br />
libnotificationmanager/jobsmodel.cpp<br />
libnotificationmanager/jobsmodel.h<br />
libnotificationmanager/jobsmodel_p.cpp<br />
libnotificationmanager/jobsmodel_p.h<br />
libnotificationmanager/kcfg/badgesettings.kcfg<br />
libnotificationmanager/kcfg/badgesettings.kcfgc<br />
libnotificationmanager/kcfg/donotdisturbsettings.kcfg<br />
libnotificationmanager/kcfg/donotdisturbsettings.kcfgc<br />
libnotificationmanager/kcfg/jobsettings.kcfg<br />
libnotificationmanager/kcfg/jobsettings.kcfgc<br />
libnotificationmanager/kcfg/notificationsettings.kcfg<br />
libnotificationmanager/kcfg/notificationsettings.kcfgc<br />
libnotificationmanager/libnotificationmanager.categories<br />
libnotificationmanager/limitedrowcountproxymodel.cpp<br />
libnotificationmanager/limitedrowcountproxymodel_p.h<br />
libnotificationmanager/notification.cpp<br />
libnotificationmanager/notification.h<br />
libnotificationmanager/notification_p.h<br />
libnotificationmanager/notificationfilterproxymodel.cpp<br />
libnotificationmanager/notificationfilterproxymodel_p.h<br />
libnotificationmanager/notificationgroupcollapsingproxymodel.cpp<br />
libnotificationmanager/notificationgroupcollapsingproxymodel_p.h<br />
libnotificationmanager/notificationgroupingproxymodel.cpp<br />
libnotificationmanager/notificationgroupingproxymodel_p.h<br />
libnotificationmanager/notifications.cpp<br />
libnotificationmanager/notifications.h<br />
libnotificationmanager/notificationsmodel.cpp<br />
libnotificationmanager/notificationsmodel.h<br />
libnotificationmanager/notificationsortproxymodel.cpp<br />
libnotificationmanager/notificationsortproxymodel_p.h<br />
libnotificationmanager/plasmanotifyrc<br />
libnotificationmanager/server.cpp<br />
libnotificationmanager/server.h<br />
libnotificationmanager/server_p.cpp<br />
libnotificationmanager/server_p.h<br />
libnotificationmanager/settings.cpp<br />
libnotificationmanager/settings.h<br />
libnotificationmanager/utils.cpp<br />
libnotificationmanager/utils_p.h</div></div></div><br /><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>nicolasfella, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>