<table><tr><td style="">zzag added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20445">View Revision</a></tr></table><br /><div><div><p>Oh, nice! FWIW, I made a patch to add HighDPI support some time ago as well. I haven't uploaded it for review because there were issues with beams not being smooth.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20445#inline-114920">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ksignalplotter.cpp:681-682</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">dpr</span> <span style="color: #aa2211">=</span> <span class="n">mScrollableImage</span><span class="p">.</span><span class="n">devicePixelRatio</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QPointF</span> <span class="n">point</span> <span style="color: #aa2211">=</span> <span class="n">boundingBox</span><span class="p">.</span><span class="n">topRight</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">QPointF</span><span class="p">(</span><span class="n">mScrollOffset</span> <span style="color: #aa2211">-</span> <span style="color: #601200">2</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QRectF</span> <span style="color: #004012">sourceRect</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span class="p">(</span><span class="n">mScrollOffset</span> <span style="color: #aa2211">-</span> <span style="color: #601200">1</span><span class="p">)</span> <span style="color: #aa2211">*</span> <span class="n">dpr</span><span class="p">,</span> <span class="n">boundingBox</span><span class="p">.</span><span class="n">height</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span class="n">dpr</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">#ifdef USE_QIMAGE</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can be const.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20445#inline-114921">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ksignalplotter.cpp:691</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span><span class="p">(</span><span class="n">widthOfSecondHalf</span> <span style="color: #aa2211">></span> <span style="color: #601200">0</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">dpr</span> <span style="color: #aa2211">=</span> <span class="n">mScrollableImage</span><span class="p">.</span><span class="n">devicePixelRatio</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QRectF</span> <span style="color: #004012">sourceRect</span><span class="p">(</span><span class="n">mScrollableImage</span><span class="p">.</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="p">(</span><span class="n">widthOfSecondHalf</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span class="p">)</span> <span style="color: #aa2211">*</span> <span class="n">dpr</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span class="n">widthOfSecondHalf</span> <span style="color: #aa2211">*</span> <span class="n">dpr</span><span class="p">,</span> <span class="n">boundingBox</span><span class="p">.</span><span class="n">height</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span class="n">dpr</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Don't abuse <tt style="background: #ebebeb; font-size: 13px;">auto</tt>.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R111 KSysguard Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20445">https://phabricator.kde.org/D20445</a></div></div><br /><div><strong>To: </strong>volkov<br /><strong>Cc: </strong>zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>