<table><tr><td style="">romangg requested changes to this revision.<br />romangg added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20186">View Revision</a></tr></table><br /><div><div><p>Nice work. Most of the stuff in libinputtouchpad.cpp and its header file are copy-paste from the Wayland backend. It would make sense to have a new abstract parent class such that the code is shared.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20186#inline-114086">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xlibbackend.h:74</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QStringList</span> <span style="color: #004012">listMouses</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QStringList</span> <span style="color: #aa2211">&</span><span class="n">blacklist</span><span class="p">)</span> <span class="n">override</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QVector</span><span style="color: #aa2211"><</span><span class="n">QObject</span><span style="color: #aa2211">*></span> <span class="n">getDevices</span><span class="p">()</span> <span style="color: #aa4000">const</span> <span class="n">override</span> <span class="p">{</span> <span style="color: #aa4000">return</span> <span class="n">m_device</span> <span style="color: #aa2211">?</span> <span class="n">QVector</span><span style="color: #aa2211"><</span><span class="n">QObject</span><span style="color: #aa2211">*></span> <span class="p">{</span> <span class="n">m_device</span><span class="p">.</span><span class="n">data</span><span class="p">()}</span> <span style="color: #aa2211">:</span> <span class="n">QVector</span><span style="color: #aa2211"><</span><span class="n">QObject</span><span style="color: #aa2211">*></span><span class="p">();</span> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Put the definition in the cpp file.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20186#inline-114085">View Inline</a><span style="color: #4b4d51; font-weight: bold;">touchpadconfiglibinput.cpp:55</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">m_backend</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="n"><span class="bright">TouchpadB</span>ackend<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">implementation</span></span><span class="bright"></span><span class="p"><span class="bright">()</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_backend</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="n"><span class="bright">b</span>ackend</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">m_initError</span> <span style="color: #aa2211">=</span> <span style="color: #aa2211">!</span><span class="n">m_backend</span><span style="color: #aa2211">-></span><span class="n">errorString</span><span class="p">().</span><span class="n">isNull</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Put it in the constructor initializer list.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20186#inline-114082">View Inline</a><span style="color: #4b4d51; font-weight: bold;">touchpadbackend.h:43</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">TouchpadInputBackendMode</span> <span class="n">m_mode</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Such a member varialbe shouldn't be public.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20186#inline-114084">View Inline</a><span style="color: #4b4d51; font-weight: bold;">touchpadbackend.h:51</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">virtual</span> <span style="color: #aa4000">bool</span> <span style="color: #004012">getDefaultConfig</span><span class="p">()</span> <span class="p">{</span><span style="color: #aa4000">return</span> <span style="color: #304a96">false</span><span class="p">;}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">virtual</span> <span style="color: #aa4000">bool</span> <span style="color: #004012">isChangedConfig</span><span class="p">()</span> <span style="color: #aa4000">const</span> <span class="p">{</span><span style="color: #aa4000">return</span> <span style="color: #304a96">false</span><span class="p">;}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">virtual</span> <span style="color: #aa4000">bool</span> <span style="color: #004012">getDefaultConfig</span><span class="p">()</span> <span class="p">{<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa4000">return</span> <span style="color: #304a96">false</span><span class="p">;<span class="bright"></span></span><span class="bright"> </span><span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">virtual</span> <span style="color: #aa4000">bool</span> <span style="color: #004012">isChangedConfig</span><span class="p">()</span> <span style="color: #aa4000">const</span> <span class="p">{<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa4000">return</span> <span style="color: #304a96">false</span><span class="p">;<span class="bright"></span></span><span class="bright"> </span><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Unnecessary changes. Revert these pls to keep the diff size in check.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20186">https://phabricator.kde.org/D20186</a></div></div><br /><div><strong>To: </strong>atulbi, ngraham, romangg, davidedmundson, Plasma<br /><strong>Cc: </strong>jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>