<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson added inline comments.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20237">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20237#inline-113944">View Inline</a><span style="color: #4b4d51; font-weight: bold;">systemmodel.cpp:57</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">QList</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span class="n"><span class="bright">SystemEntry</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*></span></span><span class="bright"> </span><span class="n"><span class="bright">actions</span></span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">actions</span> <span style="color: #aa2211"><<</span> <span style="color: #aa4000">new</span> <span class="n">SystemEntry</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SystemEntry</span><span style="color: #aa2211">::</span><span class="n">LockSession</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">actions</span> <span style="color: #aa2211"><<</span> <span style="color: #aa4000">new</span> <span class="n">SystemEntry</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SystemEntry</span><span style="color: #aa2211">::</span><span class="n">LogoutSession</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">actions</span> <span style="color: #aa2211"><<</span> <span style="color: #aa4000">new</span> <span class="n">SystemEntry</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SystemEntry</span><span style="color: #aa2211">::</span><span class="n">SaveSession</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">actions</span> <span style="color: #aa2211"><<</span> <span style="color: #aa4000">new</span> <span class="n">SystemEntry</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SystemEntry</span><span style="color: #aa2211">::</span><span class="n">SwitchUser</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">actions</span> <span style="color: #aa2211"><<</span> <span style="color: #aa4000">new</span> <span class="n">SystemEntry</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SystemEntry</span><span style="color: #aa2211">::</span><span class="n">SuspendToRam</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">actions</span> <span style="color: #aa2211"><<</span> <span style="color: #aa4000">new</span> <span class="n">SystemEntry</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SystemEntry</span><span style="color: #aa2211">::</span><span class="n">SuspendToDisk</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">actions</span> <span style="color: #aa2211"><<</span> <span style="color: #aa4000">new</span> <span class="n">SystemEntry</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SystemEntry</span><span style="color: #aa2211">::</span><span class="n">Reboot</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">actions</span> <span style="color: #aa2211"><<</span> <span style="color: #aa4000">new</span> <span class="n">SystemEntry</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SystemEntry</span><span style="color: #aa2211">::</span><span class="n">Shutdown</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">foreach</span><span class="p">(</span><span class="n">SystemEntry</span> <span style="color: #aa2211">*</span><span class="n">entry</span><span class="p">,</span> <span class="n">actions</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">entry</span><span style="color: #aa2211">-></span><span class="n">isValid</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="n">m_entryList</span> <span style="color: #aa2211"><<</span> <span class="n">entry</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #aa4000">delete</span> <span class="n">entry</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">qDeleteAll</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">m_entries</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">values</span></span><span class="bright"></span><span class="p"><span class="bright">())</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">qDeleteAll(m_entries)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20237">https://phabricator.kde.org/D20237</a></div></div><br /><div><strong>To: </strong>hein, Plasma, davidedmundson<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>