<table><tr><td style="">apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18296">View Revision</a></tr></table><br /><div><div><p>Overall this makes sense to me, this assumes though that there will never be a file ending with <tt style="background: #ebebeb; font-size: 13px;">:digit</tt>, is that something we can live with?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18296#inline-112565">View Inline</a><span style="color: #4b4d51; font-weight: bold;">urlinfo.h:68</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">             */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">line</span> <span style="color: #aa2211">=</span> <span class="n">match</span><span class="p">.</span><span class="n">captured</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">).</span><span class="n">toUInt</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">column</span> <span style="color: #aa2211">=</span> <span class="n">match</span><span class="p">.</span><span class="n">captured</span><span class="p">(</span><span style="color: #601200">2</span><span class="p">).</span><span class="n">toUInt</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">capturedRef, no need to instantiate the QString to destroy again.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R126 KDE CLI Utilities</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18296">https://phabricator.kde.org/D18296</a></div></div><br /><div><strong>To: </strong>arrowd, Plasma, KTextEditor, broulik<br /><strong>Cc: </strong>apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart<br /></div>