<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19838">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19838#inline-112045">View Inline</a><span style="color: #4b4d51; font-weight: bold;">powerdevilcore.cpp:541</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">msg</span> <span style="color: #aa2211">=</span> <span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"Placeholder is device name"</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #766510">"The battery in <span class="bright">your mouse </span>(</span><span style="color: #bb6622">\"</span><span style="color: #766510">%1</span><span style="color: #bb6622">\"</span><span style="color: #766510">) is low, and the device may turn<span class="bright"> itself</span> off at any time. "</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #766510">"Please re<span class="bright">plac</span>e or <span class="bright">charg</span>e the battery<span class="bright"> as soon as possible</span>."</span><span class="p">,</span> <span class="n">name</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"The battery in (</span><span style="color: #bb6622">\"</span><span style="color: #766510">%1</span><span style="color: #bb6622">\"</span><span style="color: #766510">) is <span class="bright">running </span>low, and the device may turn off at any time. "</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"Please re<span class="bright">charg</span>e or <span class="bright">replac</span>e the battery."</span><span class="p">,</span> <span class="n">name</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Since you removed the separation between the three cases you might as well unify the codebase into one. Now you have three separate identical strings.</p>
<p style="padding: 0; margin: 8px;">Also, "The battery in (some device) is running low" with the parenthesis is a bit awkward since now it's the sentence's subject.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19838#inline-112046">View Inline</a><span style="color: #4b4d51; font-weight: bold;">powerdevilcore.cpp:580</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">emitRichNotification</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"lowbattery"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Battery Low (%1% Remaining)"</span><span class="p">,</span> <span class="n">currentPercent</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Your battery is low. If you need to continue using your computer, either plug in your computer, or shut it down and then</span> change the battery."</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Battery running low - to continue using your computer, plug it in or shut it down and</span> change the battery."</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">return</span> <span style="color: #304a96">true</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">not a fan of that hyphen. It is in the heading, so just change the main text to "To continue using your computer..."</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19838#inline-112047">View Inline</a><span style="color: #4b4d51; font-weight: bold;">powerdevilcore.cpp:641</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"AC Adapter Plugged In"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"<span class="bright">All pending suspend actions have been canceled</span>."</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"<span class="bright">The computer will no longer go to sleep</span>."</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Sounds like from now on it will never suspend anymore.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R122 Powerdevil</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19838">https://phabricator.kde.org/D19838</a></div></div><br /><div><strong>To: </strong>rooty, VDG, Plasma, broulik, ngraham, filipf<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>