<table><tr><td style="">trmdi updated this revision to Diff 53710.<br />trmdi added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17073">View Revision</a></tr></table><br /><div><div><p>Improve some stuff:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Use smaller fontsize, lineHeight for track/artist</li>
<li class="remarkup-list-item">"Anchor" albumArtImage's bottom to playerControlsLoader's top</li>
<li class="remarkup-list-item">When artist == "", let the song name fill the width/height when possible</li>
</ul>
<ul class="remarkup-list">
<li class="remarkup-list-item">1x1 cover:</li>
</ul>
<p><a href="https://phabricator.kde.org/F6686096" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6686096: image.png</a></p>
<ul class="remarkup-list">
<li class="remarkup-list-item">non 1x1 cover (e.g. open youtube urls in VLC):</li>
</ul>
<p><a href="https://phabricator.kde.org/F6686102" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6686102: image.png</a></p>
<ul class="remarkup-list">
<li class="remarkup-list-item">when the song name is very long and the artist info is empty:</li>
</ul>
<p><a href="https://phabricator.kde.org/F6686109" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6686109: image.png</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D17073?vs=47876&id=53710">https://phabricator.kde.org/D17073?vs=47876&id=53710</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17073">https://phabricator.kde.org/D17073</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/taskmanager/package/contents/ui/ToolTipInstance.qml</div></div></div><br /><div><strong>To: </strong>trmdi, hein, broulik, ngraham, VDG<br /><strong>Cc: </strong>rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart<br /></div>