<table><tr><td style="">sitter updated this revision to Diff 53669.<br />sitter added a comment.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19612">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">

<li class="remarkup-list-item">repair dupe detection - was running on empty list</li>

<li class="remarkup-list-item">refactor bug fetching to not include comment fetching and port all users of it</li>

<li class="remarkup-list-item">stop holding all comments of all bugs in memory. we have no use for like 99% of them after parsing</li>

<li class="remarkup-list-item">rebase on master</li>

</ul>

<p>considering there's a default connection and the report dialog is bugzilla specific anyway I am kinda leaning towards doing away with bugzillalib entirely. we have little to no advantage from its singletonness</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R871 DrKonqi</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D19612?vs=53447&id=53669">https://phabricator.kde.org/D19612?vs=53447&id=53669</a></div></div><br /><div><strong>BRANCH</strong><div><div>webservice</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19612">https://phabricator.kde.org/D19612</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />

src/CMakeLists.txt<br />

src/bugzillaintegration/bugzillalib.cpp<br />

src/bugzillaintegration/bugzillalib.h<br />

src/bugzillaintegration/duplicatefinderjob.cpp<br />

src/bugzillaintegration/duplicatefinderjob.h<br />

src/bugzillaintegration/libbugzilla/CMakeLists.txt<br />

src/bugzillaintegration/libbugzilla/attachment.cpp<br />

src/bugzillaintegration/libbugzilla/attachment.h<br />

src/bugzillaintegration/libbugzilla/autotests/CMakeLists.txt<br />

src/bugzillaintegration/libbugzilla/autotests/bugtest.cpp<br />

src/bugzillaintegration/libbugzilla/autotests/bugzillatest.cpp<br />

src/bugzillaintegration/libbugzilla/autotests/connectiontest.cpp<br />

src/bugzillaintegration/libbugzilla/autotests/data/bugs.dragonplayer.json<br />

src/bugzillaintegration/libbugzilla/autotests/data/error.http<br />

src/bugzillaintegration/libbugzilla/autotests/data/hi.http<br />

src/bugzillaintegration/libbugzilla/autotests/data/product.dragonplayer.json<br />

src/bugzillaintegration/libbugzilla/autotests/data/put.http<br />

src/bugzillaintegration/libbugzilla/autotests/producttest.cpp<br />

src/bugzillaintegration/libbugzilla/bug.cpp<br />

src/bugzillaintegration/libbugzilla/bug.h<br />

src/bugzillaintegration/libbugzilla/bugzilla.cpp<br />

src/bugzillaintegration/libbugzilla/bugzilla.h<br />

src/bugzillaintegration/libbugzilla/comment.cpp<br />

src/bugzillaintegration/libbugzilla/comment.h<br />

src/bugzillaintegration/libbugzilla/connection.cpp<br />

src/bugzillaintegration/libbugzilla/connection.h<br />

src/bugzillaintegration/libbugzilla/product.cpp<br />

src/bugzillaintegration/libbugzilla/product.h<br />

src/bugzillaintegration/parsebugbacktraces.cpp<br />

src/bugzillaintegration/parsebugbacktraces.h<br />

src/bugzillaintegration/productmapping.cpp<br />

src/bugzillaintegration/productmapping.h<br />

src/bugzillaintegration/reportassistantpages_base.cpp<br />

src/bugzillaintegration/reportassistantpages_bugzilla.cpp<br />

src/bugzillaintegration/reportassistantpages_bugzilla.h<br />

src/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp<br />

src/bugzillaintegration/reportassistantpages_bugzilla_duplicates.h<br />

src/bugzillaintegration/reportinterface.cpp<br />

src/bugzillaintegration/reportinterface.h<br />

src/config-drkonqi.h.cmake<br />

src/data/debuggers/external/cdbrc<br />

src/data/debuggers/internal/cdbrc<br />

src/data/mappings<br />

src/debuggerlaunchers.cpp<br />

src/debuggerlaunchers.h<br />

src/drkonqi.cpp<br />

src/drkonqibackends.cpp<br />

src/kdbgwin/CMakeLists.txt<br />

src/kdbgwin/abstract_generator.h<br />

src/kdbgwin/kdbgwin_process.cpp<br />

src/kdbgwin/kdbgwin_process.h<br />

src/kdbgwin/main.cpp<br />

src/kdbgwin/mingw_generator.cpp<br />

src/kdbgwin/msvc_generator.cpp<br />

src/kdbgwin/process.cpp<br />

src/kdbgwin/process.h<br />

src/main.cpp<br />

src/parser/CMakeLists.txt<br />

src/parser/backtraceparser.cpp<br />

src/parser/backtraceparsercdb.cpp<br />

src/parser/backtraceparsercdb.h<br />

src/ptracer.cpp<br />

src/ptracer.h<br />

src/tests/crashtest/crashtest.cpp</div></div></div><br /><div><strong>To: </strong>sitter<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>