<table><tr><td style="">ndavis added subscribers: trickyricky26, ndavis.<br />ndavis requested changes to this revision.<br />ndavis added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19606">View Revision</a></tr></table><br /><div><div><p>I like it overall, but some of those icons need changing. Not just here, but in breeze-icons as well.</p>
<p>Resize: I don't like how busy that icon looks, but I"m not sure if it's worth it to make a new icon just for resizing windows.<br />
Maximize: The maximize icon is more like a "Maximized" icon because we normally use the up arrow for "Maximize".</p>
<p><a href="https://phabricator.kde.org/p/trickyricky26/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@trickyricky26</a> is already working on the shade icon and I know you requested keep-above and keep-below icons, so I'll ignore those for now.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19606#inline-109722">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ContextMenu.qml:569</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">text:</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"&Fullscreen"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">icon:</span> <span style="color: #766510">"window-keep-above"</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why was this changed from <tt style="background: #ebebeb; font-size: 13px;">view-fullscreen</tt>?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19606">https://phabricator.kde.org/D19606</a></div></div><br /><div><strong>To: </strong>ngraham, Plasma, VDG, ndavis<br /><strong>Cc: </strong>ndavis, trickyricky26, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>