<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19606">View Revision</a></tr></table><br /><div><div><p>Overall I must say I'm quite a fan.</p>
<p>I don't like the Settings and Alternatives entries at the top, they draw most attention to them for actions that should rather be least intrusive.<br />
I would prefer the jump list actions stuff at the top but grouping them with the other window/application actions is an interesting approach.<br />
While I personally don't use the Minimize/Maximize actions in the menu I've seen people get quite passionate about them.</p>
<p>Did you test how media controls behave in this scenario? Also please make sure keyboard accelerators (Alt key, the <tt style="background: #ebebeb; font-size: 13px;">&</tt> stuff) are sane.</p>
<p>Also keep in mind to adjust KWin's title bar menu to use the new icons as well.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19606#inline-109738">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ContextMenu.qml:99</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">var</span> <span style="color: #004012">lists</span> <span style="color: #aa2211">=</span> <span class="p">[</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">backend</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">jumpList</span>Actions</span><span class="p">(</span><span style="color: #004012">launcherUrl</span><span class="p">,</span> <span style="color: #004012">menu</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">backend</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">places</span>Actions</span><span class="p">(</span><span style="color: #004012">launcherUrl</span><span class="p">,</span> <span class="bright"></span><span style="color: #004012"><span class="bright">showAllPlaces</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #004012">menu</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Places"</span></span><span class="bright"></span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span style="color: #004012">backend</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">places</span>Actions</span><span class="p">(</span><span style="color: #004012">launcherUrl</span><span class="p">,</span> <span class="bright"></span><span style="color: #004012"><span class="bright">showAllPlaces</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #004012">menu</span><span class="p">)<span class="bright">]</span>,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Recent Documents"</span></span><span class="bright"></span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span style="color: #004012">backend</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">recentDocument</span>Actions</span><span class="p">(</span><span style="color: #004012">launcherUrl</span><span class="p">,</span> <span style="color: #004012">menu</span><span class="p">)<span class="bright">]</span>,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please use a JS object for that instead of using just numbered indices</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">var list = [
{title: i18n("Places"), actions: backend. ...},
{title: i18n("Recent Documents"), actions: ...}
...
];</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19606#inline-109739">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ContextMenu.qml:112</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// This section with the one beneath it that shows universal actions</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #004012">list</span><span class="p">[</span><span style="color: #601200">1</span><span class="p">].</span><span style="color: #004012">length</span> <span style="color: #aa2211">></span> <span style="color: #601200">0</span> <span style="color: #aa2211">||</span> <span style="color: #004012">list</span><span class="p">[</span><span style="color: #601200">0</span><span class="p">]</span> <span style="color: #aa2211">==</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Actions"</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">var</span> <span style="color: #004012">sectionHeader</span> <span style="color: #aa2211">=</span> <span style="color: #004012">newMenuItem</span><span class="p">(</span><span style="color: #004012">menu</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Comparing translated strings is usually bad style, please use my idea above, and then perhaps add a third <tt style="background: #ebebeb; font-size: 13px;">group: "actions"</tt> or similar string for identification</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19606#inline-109741">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ContextMenu.qml:119</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">var</span> <span style="color: #004012">key</span> <span style="color: #aa4000">in</span> <span style="color: #004012">list</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">var</span> <span style="color: #004012">i</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span> <span style="color: #004012">i</span> <span style="color: #aa2211"><</span> <span style="color: #004012">list</span><span class="p">[</span><span style="color: #601200">1</span><span class="p">].</span><span style="color: #004012">length</span><span class="p">;</span> <span style="color: #aa2211">++</span><span style="color: #004012">i</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Remove</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19606#inline-109742">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ContextMenu.qml:320</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">text:</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Move To &Desktop"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">icon:</span> <span style="color: #766510">"go-next"</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't see the point of this icon, it adds visual noise for no better identification</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19606#inline-109744">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ContextMenu.qml:711</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">text:</span> <span style="color: #004012">i18nc</span><span class="p">(</span><span style="color: #766510">"Remove launcher button for application shown while it is not running"</span><span class="p">,</span> <span style="color: #766510">"Unpin<span class="bright">"</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">text:</span> <span style="color: #004012">i18nc</span><span class="p">(</span><span style="color: #766510">"Remove launcher button for application shown while it is not running"</span><span class="p">,</span> <span style="color: #766510">"Unpin<span class="bright"> from %1"</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">plasmoid</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">title</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">icon:</span> <span style="color: #766510">"window-pin"</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Perhaps add some context explaining %1 is plasmoid title?</p>
<p style="padding: 0; margin: 8px;">However, I can already see this becoming quite awful in German in case of icon tasks "An Fensterleiste nur mit Symbolen anheften" :/</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19606">https://phabricator.kde.org/D19606</a></div></div><br /><div><strong>To: </strong>ngraham, Plasma, VDG, ndavis<br /><strong>Cc: </strong>broulik, ndavis, trickyricky26, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>