<table><tr><td style="">sitter added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19596">View Revision</a></tr></table><br /><div><div><p>The sidepanel (which I guess is the mainview) gets the icon from InfoKcmModel::data from what I can tell. ::data and ::generateToolTipLine are the only places where I see ::icon get called. So what I am thinking is these changes:</p>
<p>::icon goes away in favor of</p>
<p><tt style="background: #ebebeb; font-size: 13px;">QString KcmTreeItem::iconName() { return m_kcm.icon() }</tt></p>
<p>and</p>
<p><tt style="background: #ebebeb; font-size: 13px;">QString KcmCategoryItem::iconName() { return m_category.icon() }</tt></p>
<p>and the model creates a regular unaltered QIcon</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">QVariant InfoKcmModel::data(const QModelIndex &index, int role) const
{
...
case Qt::DecorationRole:
return QIcon::fromTheme(item->iconName());
...
}</pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19596">https://phabricator.kde.org/D19596</a></div></div><br /><div><strong>To: </strong>mart, Plasma, sitter<br /><strong>Cc: </strong>ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>