<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19214">View Revision</a></tr></table><br /><div><div><p>Looks like <a href="https://bugs.kde.org/show_bug.cgi?id=399155" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=399155</a> has revealed that the text field itself just isn't tall enough. Fixing that should fix both the bug mentioned above, as well as the hackaround to make the button shorter so they're the same height.</p>
<p>Let's either fix the issue in the PlasmaComponents text field before we land this, or else see if we can port this to use the Kirigami <tt style="background: #ebebeb; font-size: 13px;">ActionTextField</tt> instead, which should be the correct height.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19214">https://phabricator.kde.org/D19214</a></div></div><br /><div><strong>To: </strong>rooty, VDG, Plasma, ngraham, filipf<br /><strong>Cc: </strong>ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>