<table><tr><td style="">jgrulich accepted this revision.<br />jgrulich added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19306">View Revision</a></tr></table><br /><div><div><p>Good idea to remove the failed connection.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19306#inline-108699">View Inline</a><span style="color: #4b4d51; font-weight: bold;">secretagent.cpp:412</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">sendError</span><span class="p">(</span><span class="n">SecretAgent</span><span style="color: #aa2211">::</span><span class="n">NoSecrets</span><span class="p">,</span> <span style="color: #766510">"Cannot authenticate"</span><span class="p">,</span> <span class="n">request</span><span class="p">.</span><span class="n">message</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">emit</span> <span style="color: #004012">secretsError</span><span class="p">(</span><span class="n">request</span><span class="p">.</span><span class="n">connection_path</span><span class="p">.</span><span class="n">path</span><span class="p">(),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Authentication to %1 failed. Wrong password?"</span><span class="p">,</span> <span class="n">request</span><span class="p">.</span><span class="n">connection</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span style="color: #766510">"connection"</span><span class="p">).</span><span class="n">value</span><span class="p">(</span><span style="color: #766510">"id"</span><span class="p">).</span><span class="n">toString</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">return</span> <span style="color: #304a96">true</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'm not sure this assumption is currect, it's not that the password is wrong all the time, NM might be just asking for additional passwords or for passwords which are marked not to be stored (e.g. VPN, or WPA2 EAP). But I guess for your usecase we can leave it as it is, we just need to make sure that Configuration::showPasswordDialog() will be true only on plasma-mobile.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19306#inline-108700">View Inline</a><span style="color: #4b4d51; font-weight: bold;">handler.h:107</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">void</span> <span class="n">initKdedModule</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">void</span> <span style="color: #004012">secretAgentError</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">a</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">b</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">void</span> <span style="color: #004012">replyFinished</span><span class="p">(</span><span class="n">QDBusPendingCallWatcher</span> <span style="color: #aa2211">*</span><span class="n">watcher</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">void secretAgentError(const QString &connectionPath, const QString &message)</p>

<p style="padding: 0; margin: 8px;">so we know on first look what are these params?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R116 Plasma Network Management Applet</div></div></div><br /><div><strong>BRANCH</strong><div><div>phab/errorSignal</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19306">https://phabricator.kde.org/D19306</a></div></div><br /><div><strong>To: </strong>mart, Plasma, jgrulich, bshah<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>