<table><tr><td style="">simgunz added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19312">View Revision</a></tr></table><br /><div><div><p>I never landed a diff before because I just got my KDE developer account. <br />
Few general questions:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Is it enough that one reviewer accept the revision, or all the listed ones should accept it? (or depends on the project?)</li>
<li class="remarkup-list-item">Can I directly land it once the condition above is satisfied, or is it always better to ask before landing it?</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R111 KSysguard Library</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19312">https://phabricator.kde.org/D19312</a></div></div><br /><div><strong>To: </strong>simgunz, Plasma, cfeck, broulik, mart<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>