<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19392">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>so, we colorize monochrome icons treating them as just masks, and that works ok, tough there isn't any spec to know with 100% certainty if an icon is monochrome or colored (all icon names that end up with -symbolys usually are monochrome, but in breeze and other themes monochrome icons are all over the place and often it depends from the icon size)</p></blockquote>
<p>For breeze there's an alternate approach. We "just" add "-symbolic" symlinks in everywhere. We could even use this code to automate doing that. That would cover the android case.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Or technically one can do a kirigami app with zero dependencies and not have qqc2-desktop-style installed and run it on gnome.</p></blockquote>
<p>It seems gnome themes also do the -symbolic suffix thing and do SVG replacement like we do. With very similar keys too!<br />
Even ignoring this Kirigami issue we have an issue of Breeze icons on gnome and vice versa that's worth fixing.</p>
<p>If we need to do this as a temporary measure, then fine.</p>
<p>However, I want to hear a plan on what a "correct" cross-desktop KF6 + Qt6 solution would be - and maybe start some ML threads together before accepting. <br />
Otherwise we'll carry on with hacks that only half work forever and ever.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19392#inline-108332">View Inline</a><span style="color: #4b4d51; font-weight: bold;">desktopicon.cpp:494</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">const</span> <span class="n">QColor</span> <span class="n">tintColor</span> <span style="color: #aa2211">=</span> <span style="color: #aa2211">!</span><span class="n">m_color</span><span class="p">.</span><span class="n">isValid</span><span class="p">()</span> <span style="color: #aa2211">||</span> <span class="n">m_color</span> <span style="color: #aa2211">==</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">transparent</span> <span style="color: #aa2211">?</span> <span class="p">(</span><span class="n">m_selected</span> <span style="color: #aa2211">?</span> <span class="n">m_theme</span><span style="color: #aa2211">-></span><span class="n">highlightedTextColor</span><span class="p">()</span> <span style="color: #aa2211">:</span> <span class="n">m_theme</span><span style="color: #aa2211">-></span><span class="n">textColor</span><span class="p">())</span> <span style="color: #aa2211">:</span> <span class="n">m_color</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Will this code ever get called if we are using the KIconLoader? We want to avoid that. (Even if it's just looking at QIcon.engine()->metaObject)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19392#inline-108309">View Inline</a><span style="color: #4b4d51; font-weight: bold;">desktopicon.cpp:496</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_isMask</span> <span style="color: #aa2211">||</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #74777d">//this is an heuristic to decide when to tint and when to just draw</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #74777d">//(fullcolor icons) in reality on basic styles the only colored icons should be -symbolic, this heuristic is the most compatible middle ground</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">icon</span><span class="p">.</span><span class="n">isMask</span><span class="p">()</span> <span style="color: #aa2211">||</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #74777d">//if symbolic color based on tintColor</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">(</span><span class="n">iconSource</span><span class="p">.</span><span class="n">endsWith</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"-symbolic"</span><span class="p">))</span> <span style="color: #aa2211">&&</span> <span class="n">tintColor</span><span class="p">.</span><span class="n">isValid</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span class="n">tintColor</span> <span style="color: #aa2211">!=</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">transparent</span><span class="p">)</span> <span style="color: #aa2211">||</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #74777d">//if path color based on m_color</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">(</span><span class="n">isPath</span> <span style="color: #aa2211">&&</span> <span class="n">m_color</span><span class="p">.</span><span class="n">isValid</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span class="n">m_color</span> <span style="color: #aa2211">!=</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">transparent</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_isMask</span> <span style="color: #aa2211">||<span class="bright"></span></span><span class="bright"> </span><span class="n"><span class="bright">icon</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">isMask</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">||</span></span><span class="bright"> </span><span class="n"><span class="bright">iconSource</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">endsWith</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"-symbolic"</span></span><span class="bright"></span><span class="p"><span class="bright">))</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">||</span></span><span class="bright"> </span><span class="n"><span class="bright">guessMonochrome</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">img</span></span><span class="bright"></span><span class="p"><span class="bright">))</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QPainter</span> <span class="n">p</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">img</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Do we need to test:</p>
<p style="padding: 0; margin: 8px;">-symbolic<br />
-symbolic-ltr<br />
-symbolic-rtl</p>
<p style="padding: 0; margin: 8px;">(I saw this in some gnome code)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19392#inline-108307">View Inline</a><span style="color: #4b4d51; font-weight: bold;">platformtheme.cpp:695</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="n">QIcon</span> <span class="n">PlatformTheme</span><span style="color: #aa2211">::</span><span class="n">iconFromTheme</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">name</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QColor</span> <span style="color: #aa2211">&</span><span class="n">customColor</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is this useful if DesktopIcon does this anyway?</p>
<p style="padding: 0; margin: 8px;">(or to turn the question around, can we do it all here and have DesktopIcon only check isMask)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19392">https://phabricator.kde.org/D19392</a></div></div><br /><div><strong>To: </strong>mart, Kirigami<br /><strong>Cc: </strong>cfeck, davidedmundson, plasma-devel, domson, dkardarakos, apol, mart, hein<br /></div>