<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19325">View Revision</a></tr></table><br /><div><div><p>I expected to hate this, but it turns out I don't. :) It looks legible enough with all the backgrounds I typically test against except for the most challenging ones of all for white text:</p>
<p><a href="https://phabricator.kde.org/F6639743" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6639743: Snowy trees.png</a></p>
<p><a href="https://phabricator.kde.org/F6639746" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6639746: Snowy horse.png</a></p>
<p>Other semi-challenging backgrounds work okay:</p>
<p><a href="https://phabricator.kde.org/F6639744" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6639744: Dao.png</a></p>
<p><a href="https://phabricator.kde.org/F6639747" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6639747: Iceberg.png</a></p>
<p><a href="https://phabricator.kde.org/F6639748" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6639748: Synapse.png</a></p>
<p>Also, +1 for making the color "black" again. In retrospect I don't think using a color from the theme makes sense. Shadows should always be black, not dark gray or any other color (which would make them into a glow, not a shadow).</p>
<p>However, the Request Changes is for two reasons:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">Shouldn't we do this for the shadows under the usernames too?</li>
<li class="remarkup-list-item">I'm not sold on the visual appearance. No other shadow in KDE Software that I'm familiar with looks like this, with a low spread, a hard edge, and the light source shining from the top left. It's not that it looks bad, but it doesn't look like it really fits in with anything else. Thoughts?</li>
</ol></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19325">https://phabricator.kde.org/D19325</a></div></div><br /><div><strong>To: </strong>rooty, VDG, ngraham, filipf, mart<br /><strong>Cc: </strong>mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>