<table><tr><td style="">rooty marked an inline comment as done.<br />rooty added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19325">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D19325#420388" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D19325#420388</a>, <a href="https://phabricator.kde.org/p/ngraham/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ngraham</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Ah, I see now! I even implemented that, touché. :)</p>
<p>Also, why did you change the shadow from a layer effect to a separate item? If that's necessary, it would seem to be appropriate material for another patch since it's not a visual change (unless I'm not noticing it).</p></div>
</blockquote>
<p>Because it says "Cannot assign to non-existent property "layers""<br />
I don't know what I'm doing wrong</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>However, the Request Changes is for two reasons:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">Shouldn't we do this for the shadows under the usernames too?</li>
<li class="remarkup-list-item">I'm not sold on the visual appearance. No other shadow in KDE Software that I'm familiar with looks like this, with a low spread, a hard edge, and the light source shining from the top left. It's not that it looks bad, but it doesn't look like it really fits in with anything else. Thoughts?</li>
</ol></blockquote>
<ol class="remarkup-list">
<li class="remarkup-list-item">Separate patch (I've written it but I haven't committed it yet). The action buttons too.</li>
<li class="remarkup-list-item">DesktopContainment does, that's where I got the idea (<span class="phabricator-remarkup-mention-unknown">@flipwise</span>'s mockups too)</li>
</ol></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19325#inline-107974">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ngraham</span> wrote in <span style="color: #4b4d51; font-weight: bold;">Clock.qml:44</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">If we're emulating the shadows in <a href="https://phabricator.kde.org/D16968" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D16968</a>, shouldn't this be 0.35?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Yes, but doesn't it look too jagged when it's 0.35?</p>
<p style="padding: 0; margin: 8px;">0.35:<br />
<a href="https://phabricator.kde.org/F6639986" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6639986: image.png</a><br />
0.25:<br />
<a href="https://phabricator.kde.org/F6639988" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6639988: image.png</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19325">https://phabricator.kde.org/D19325</a></div></div><br /><div><strong>To: </strong>rooty, VDG, ngraham, filipf, mart<br /><strong>Cc: </strong>mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>