<table><tr><td style="">Zren created this revision.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />Zren requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19233">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This also fixes the <tt style="background: #ebebeb; font-size: 13px;">Background { id: backgroundButtons }</tt> not hiding by binding it's visibility to <tt style="background: #ebebeb; font-size: 13px;">buttons.visible</tt>.</p>

<p>Is the "bugfix" worth splitting into it's own commit and backporting to 5.15, while the new feature goes into master/5.16?</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Patch <tt style="background: #ebebeb; font-size: 13px;">/usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/views/</tt></li>
<li class="remarkup-list-item">Compile and run <tt style="background: #ebebeb; font-size: 13px;">build/bin/plasmoidviewer -a org.plasma.digitalclock --nobuttons</tt></li>
<li class="remarkup-list-item">Run <tt style="background: #ebebeb; font-size: 13px;">build/bin/plasmoidviewer -a org.plasma.digitalclock</tt> and confirm the "hide" button still works.</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R118 Plasma SDK</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19233">https://phabricator.kde.org/D19233</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>plasmoidviewer/main.cpp<br />
plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml<br />
plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml<br />
plasmoidviewer/view.cpp<br />
plasmoidviewer/view.h</div></div></div><br /><div><strong>To: </strong>Zren<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>