<table><tr><td style="">sitter created this revision.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />sitter requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19188">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>the module help button specifically launches the help for DocPath set in<br />
the desktop file of the KCM, previously the code however only checked if<br />
the KCM pragmatically disabled the help button. while supposedly its good<br />
form for a module to explicitly disable the help button when it has no help<br />
but since that depends on humans to remember doing that it's a bit<br />
unreliable.</p>
<p>so, the module help button now only gets enabled when there actually is<br />
module help available AND the button wasn't explicitly disabled.<br />
this prevents the help button from getting enabled but then launching<br />
the generic khelpcenter since no actual DocPath was set in the kcm<br />
desktop metadata</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">about (has no doc and disables button) -> disabled button</li>
<li class="remarkup-list-item">memory (has doc) -> enabled button</li>
<li class="remarkup-list-item">energy (has no doc but doesn't explicitly disable button) -> disabled button</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br /><div><strong>BRANCH</strong><div><div>better-help</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19188">https://phabricator.kde.org/D19188</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>infocenter.cpp</div></div></div><br /><div><strong>To: </strong>sitter<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>