<table><tr><td style="">ngraham added a subscriber: mart.<br />ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19173">View Revision</a></tr></table><br /><div><div><p>Also as <a href="https://phabricator.kde.org/p/mart/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@mart</a> pointed out in <a href="https://phabricator.kde.org/D19044" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D19044</a>, it might make sense to do all the styling in the qqc2 desktop style theme for this control, rather than here in Kirigami itself.</p>
<p>Finally, I'm requiring that any change to this control be mirrored in the QWidgets version too (<tt style="background: #ebebeb; font-size: 13px;">KMessageWidget</tt> in <tt style="background: #ebebeb; font-size: 13px;">KWidgetsAddons</tt>): <a href="https://cgit.kde.org/kwidgetsaddons.git/tree/src/kmessagewidget.cpp" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/kwidgetsaddons.git/tree/src/kmessagewidget.cpp</a>. I put a lot of work into harmonizing their visual styles and I don't want them to drift subtly out of sync again. :)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19173">https://phabricator.kde.org/D19173</a></div></div><br /><div><strong>To: </strong>filipf, Kirigami, VDG, ngraham<br /><strong>Cc: </strong>mart, plasma-devel, dkardarakos, apol, davidedmundson, hein<br /></div>