<table><tr><td style="">zzag added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15907">View Revision</a></tr></table><br /><div><div><p>Looks good to me.</p>

<p>I think the test is too much complicated. Would it be simpler to have something like</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span class="n">QTest</span><span style="color: #aa2211">::</span><span class="n">addColumn</span><span style="color: #aa2211"><</span><span class="n">QRectF</span><span style="color: #aa2211">></span><span class="p">(</span><span style="color: #766510">"geometry"</span><span class="p">);</span>
<span class="n">QTest</span><span style="color: #aa2211">::</span><span class="n">addColumn</span><span style="color: #aa2211"><</span><span class="n">QPointF</span><span style="color: #aa2211">></span><span class="p">(</span><span style="color: #766510">"pos"</span><span class="p">);</span>
<span class="n">QTest</span><span style="color: #aa2211">::</span><span class="n">addColumn</span><span style="color: #aa2211"><</span><span style="color: #aa4000">bool</span><span style="color: #aa2211">></span><span class="p">(</span><span style="color: #766510">"contains"</span><span class="p">);</span></pre></div>

<p>?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15907#inline-106659">View Inline</a><span style="color: #4b4d51; font-weight: bold;">decorationbutton.cpp:455</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">// additional make sure pos is not on the right or bottom edge</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span style="color: #aa4000">bool</span> <span class="n">verInside</span> <span style="color: #aa2211">=</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">geometry</span><span class="p">.</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211"><</span> <span style="color: #601200">0</span> <span style="color: #aa2211">?</span> <span class="n">pos</span><span class="p">.</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211"><</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">geometry</span><span class="p">.</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                                     <span class="n">pos</span><span class="p">.</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211"><</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">geometry</span><span class="p">.</span><span class="n">right</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No short names.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R129 Window Decoration Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15907">https://phabricator.kde.org/D15907</a></div></div><br /><div><strong>To: </strong>romangg, KWin, zzag, davidedmundson<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>