<table><tr><td style="">Zren created this revision.<br />Zren added a reviewer: Plasma.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />Zren requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19021">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>In 12h system locales (eg: en_US), checked=1 is cast as<br />
Qt::PartiallyChecked=1 which defaults to the system locale (12h).<br />
Since it's no longer a tri-state button, the user can't select<br />
Qt::Checked=2 which forces the 24h state.</p>
<p>BUG: 404292</p>
<p>FIXED-IN: 5.15.1</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Run <tt style="background: #ebebeb; font-size: 13px;">LC_TIME="en_US.UTF-8" plasmoidviewer -a org.kde.plasma.digitalclock</tt> and confirm it's a 2 state button that doesn't enable 24h clock.</li>
<li class="remarkup-list-item">Patch <tt style="background: #ebebeb; font-size: 13px;">/usr/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/configAppearance.qml</tt></li>
<li class="remarkup-list-item">Run <tt style="background: #ebebeb; font-size: 13px;">LC_TIME="en_US.UTF-8" plasmoidviewer -a org.kde.plasma.digitalclock</tt> and confirm it's a 3 state button that does force the 24h clock.</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19021">https://phabricator.kde.org/D19021</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/digital-clock/package/contents/ui/configAppearance.qml</div></div></div><br /><div><strong>To: </strong>Zren, Plasma<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>