<table><tr><td style="">andrzej1_1 created this revision.<br />andrzej1_1 added a project: Breeze.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />andrzej1_1 requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18999">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>When I was running <em>GTK3</em> application <em>pavucontrol</em>, I was getting warnings:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">(pavucontrol:10863): Gtk-WARNING **: 10:09:55.669: Theme parsing error: gtk.css:127:35: The style property GtkButton:child-displacement-x is deprecated and shouldn't be used anymore. It will be removed in a future version
(pavucontrol:10863): Gtk-WARNING **: 10:09:55.669: Theme parsing error: gtk.css:128:35: The style property GtkButton:child-displacement-y is deprecated and shouldn't be used anymore. It will be removed in a future version
(pavucontrol:10863): Gtk-WARNING **: 10:09:55.669: Theme parsing error: gtk.css:129:34: The style property GtkCheckButton:indicator-size is deprecated and shouldn't be used anymore. It will be removed in a future version
(pavucontrol:10863): Gtk-WARNING **: 10:09:55.669: Theme parsing error: gtk.css:130:36: The style property GtkCheckMenuItem:indicator-size is deprecated and shouldn't be used anymore. It will be removed in a future version
(pavucontrol:10863): Gtk-WARNING **: 10:09:55.669: Theme parsing error: gtk.css:132:46: The style property GtkScrolledWindow:scrollbars-within-bevel is deprecated and shouldn't be used anymore. It will be removed in a future version
(pavucontrol:10863): Gtk-WARNING **: 10:09:55.669: Theme parsing error: gtk.css:135:30: The style property GtkExpander:expander-size is
deprecated and shouldn't be used anymore. It will be removed in a future version
(pavucontrol:10863): Gtk-WARNING **: 10:09:55.669: Theme parsing error: gtk.css:142:29: The style property GtkStatusbar:shadow-type is deprecated and shouldn't be used anymore. It will be removed in a future version</pre></div>
<p>This was annoying, so I decided to fix it. Firstly I thought it is a application problem, but then I discovered it is <em>breeze-gtk</em> issue. For example <em>GTK3</em> documentation states that:</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>GtkStatusbar:shadow-type has been deprecated since version 3.20 and should not be used in newly-written code.</p>
<p>Use CSS properties to determine the appearance, the value of this style property is ignored.</p></blockquote>
<p>So if some styles are ignored, I can remove them and get rid of part of warnings:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">I wrote python script for finding all deprecation messages in docs: <a href="https://phabricator.kde.org/F6614333" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6614333: find-deprecated-styles.py</a></li>
<li class="remarkup-list-item">I ran script and saved results to file</li>
<li class="remarkup-list-item">I used it to find all ignored properties in CSS:</li>
</ol>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="console" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #000080">$ find-deprecated-styles.py > /tmp/gtk-deprecated.txt</span>
<span style="color: #000080">$ cd breeze-gtk/src/gtk320/</span>
<span style="color: #000080">$ cat /tmp/gtk-deprecated.txt | sed -n 's/^ \* \([^ ]*\).*the value of this style property is ignored.*$/\1/p' | tr : - | while read style; do grep -Rn $style; done</span>
<span style="color: #808080">widgets/_base.scss:40: -GtkStatusbar-shadow-type: none;</span>
<span style="color: #808080">widgets/_base.scss:12: -GtkButton-child-displacement-x: 0;</span>
<span style="color: #808080">widgets/_base.scss:13: -GtkButton-child-displacement-y: 0;</span>
<span style="color: #808080">widgets/_base.scss:16: -GtkCheckMenuItem-indicator-size: 18;</span>
<span style="color: #808080">widgets/_base.scss:24: -GtkScrolledWindow-scrollbars-within-bevel: 0;</span></pre></div>
<p>Then I just removed them.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R98 Breeze for Gtk</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18999">https://phabricator.kde.org/D18999</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/gtk320/widgets/_base.scss</div></div></div><br /><div><strong>To: </strong>andrzej1_1<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, trickyricky26, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>