<table><tr><td style="">davidre added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18809">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D18809#407355" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D18809#407355</a>, <a href="https://phabricator.kde.org/p/ngraham/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ngraham</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>This is a huge improvement over what we have right now. Very nice job!</p></div>
</blockquote>
<p>Thanks!</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>A few behavioral issues:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">After removing a folder, the wallpaper grid should update immediately to reflect that</li>
</ul></blockquote>
<p>It doesn't work for you? Maybe I missed something in the diff, I will try to upload a video.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item">The individual elements in the wallpaper grid now can't be individually chosen as wallpapers, so there's no need for them to be selectable anymore</li>
</ul></blockquote>
<p>I think I need help with that.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>And a design issue: now that it's not taking up the full width, the folder list manages to feel space-inefficient while also eliding the text most of the time. And there's not so much room left for the wallpaper grid so it feels a bit scrunched, especially in System Settings at the default window size:<br />
<a href="https://phabricator.kde.org/F6598236" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6598236: A bit scrunched.png</a></p>
<p>I would recommend showing just the folder name, not the full path. Then you can reduce its width a bit, so that it's say, a maximum of 25% of the total layout width. Right now it's more like 33-40% of the total width most of the time which feels too wide.</p></blockquote>
<p>Done. Now the problem is, that if you add two folders with the same name you cannot know which is which, Maybe it would be possible to add a tooltip?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Ideas for further improvement (not necessary in this patch, but nice to have)</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">The Remove button should show up on hover rathet than being always visible. If you use a Kirigami <tt style="background: #ebebeb; font-size: 13px;">SwipeListItem</tt> instead of a <tt style="background: #ebebeb; font-size: 13px;">BasicListItem</tt>, this will happen automatically if you implement the remove button as an action. Here is an example: <a href="https://cgit.kde.org/discover.git/tree/discover/qml/SourcesPage.qml#n160" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/discover.git/tree/discover/qml/SourcesPage.qml#n160</a></li>
</ul></blockquote>
<p>Done.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item">It might be nice to add an "Open Containing Folder" action to the folder list items, too</li>
</ul></blockquote>
<p>Done.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18809">https://phabricator.kde.org/D18809</a></div></div><br /><div><strong>To: </strong>davidre, VDG, ngraham<br /><strong>Cc: </strong>davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>