<table><tr><td style="">sitter created this revision.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />sitter requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18807">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>I'm in a good mood so there's even finders!</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">FindCanberra now also sets the version (this is necessary to hint directories for the pulse backend lookup)</li>
<li class="remarkup-list-item">new FindCanberraPulse attempts to find the canberra-pulse backend using manually constructed hinting (unfortunately canberra's pc doesn't define the dir so we'll basically have to guess)</li>
<li class="remarkup-list-item">new FindSoundThemeFreedesktop which locates the freedesktop sound theme we actually require for the notification sound (since we have no plasma sound theme :()</li>
</ul>
<p>The new finders are put to use to locate and indicate RUNTIME dependencies.<br />
As with all runtime deps, if the finders should proof unreliable<br />
CMAKE_DISABLE_FIND_PACKAGE_* can be used to easily silence the warnings.<br />
They may of course also be safely ignored.</p>
<p>Getting canberra and the sound-theme dependency right has proven a<br />
challenge to distributions. The problem goes back even to when kde-runtime<br />
was still a thing and used canberra, and AFAIK wasn't even resolved by<br />
all distributions by the time plasma 5 came around and kde-runtime killed<br />
off. So, clearly we need to help things along a bit by properly codifying<br />
and communicating the requirements here.</p>
<p>The volume feedback is effectively disabled when the pulse backend cannot<br />
be loaded, and the actual feedback sound is by default coming from the<br />
default xdg theme which also must be available for the feedback to work.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume Applet</div></div></div><br /><div><strong>BRANCH</strong><div><div>runtime-deps</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18807">https://phabricator.kde.org/D18807</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
cmake/FindCanberra.cmake<br />
cmake/FindCanberraPulse.cmake<br />
cmake/FindSoundThemeFreedesktop.cmake</div></div></div><br /><div><strong>To: </strong>sitter<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>