<table><tr><td style="">mvourlakos added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18717">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18717#inline-104264">View Inline</a><span style="color: #4b4d51; font-weight: bold;">globalshortcuts.cpp:810</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span class="n">sortedViewsList</span><span class="p">(</span><span class="n">m_corona</span><span style="color: #aa2211">-></span><span class="n">layoutManager</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">currentLatteViews</span><span class="p">())[</span><span style="color: #601200">0</span><span class="p">];</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><ol class="remarkup-list">
<li class="remarkup-list-item">this can create a crash when there are no views at all shown.</li>
</ol>
<p style="padding: 0; margin: 8px;">please make a check that sortedViewsList returns <strong>count()>0</strong> and if it doesnt it can return a <strong>nullptr</strong></p>
<ol class="remarkup-list" start="2">
<li class="remarkup-list-item">the function <strong>highestPriorityView</strong> probably needs to be moved at layout and <strong>sortedViewsList</strong> at the same time but that can be a different commit after this commit has landed because the <strong>sortedViewList</strong> is used I think in more places at globalshortcuts</li>
</ol></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R878 Latte Dock</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18717">https://phabricator.kde.org/D18717</a></div></div><br /><div><strong>To: </strong>trmdi, mvourlakos<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>