<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18182">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18182#inline-102323">View Inline</a><span style="color: #4b4d51; font-weight: bold;">foldermodel.cpp:170</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">connect</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">QAbstractItemModel</span><span style="color: #aa2211">::</span><span class="n">rowsInserted</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">](</span><span style="color: #aa4000">const</span> <span class="n">QModelIndex</span> <span style="color: #aa2211">&</span><span class="n">parent</span><span class="p">,</span> <span style="color: #aa4000">int</span> <span class="n">first</span><span class="p">,</span> <span style="color: #aa4000">int</span> <span class="n">last</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">i</span> <span style="color: #aa2211">=</span> <span class="n">first</span><span class="p">;</span> <span class="n">i</span> <span style="color: #aa2211"><=</span> <span class="n">last</span><span class="p">;</span> <span style="color: #aa2211">++</span><span class="n">i</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'm a bit worried about queuing something with indexes. Indexes are only valid at that exact moment.</p>

<p style="padding: 0; margin: 8px;">If the source model does the following:<br />
beginInsertRows(AA);<br />
endInsertRows()<br />
beginInsertRows(BB);<br />
endInsertRows()<br />
then exits back to the event loop</p>

<p style="padding: 0; margin: 8px;">When you process the delayed connection for the first insertion the old first/last could be pointing anywhere.</p>

<p style="padding: 0; margin: 8px;">We could maybe get round this by converting to QPeristentModelIndexes immediately, then queue up the operation that uses them.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18182">https://phabricator.kde.org/D18182</a></div></div><br /><div><strong>To: </strong>hein, Plasma, McPain<br /><strong>Cc: </strong>davidedmundson, fvogt, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>