<table><tr><td style="">broulik updated this revision to Diff 50181.<br />broulik edited the test plan for this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-lkflvex3ca6l5uw/">(Show Details)</a><br />broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12278">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">
<li class="remarkup-list-item">Cleanup a bit</li>
<li class="remarkup-list-item">Disable KCM while a file is being downloaded</li>
<li class="remarkup-list-item">Fix modal stuff for scheme editor</li>
</ul></div></div><br /><div><strong>CHANGES TO TEST PLAN</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>Minor issues:<br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">* KColorSchemeEditor isn't modal to the KCM<br />
</span>* KColorSchemeEditor lacks an OK button so when launched from the KCM you always have to do Save/Apply and Close instead.</div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D12278?vs=50175&id=50181">https://phabricator.kde.org/D12278?vs=50175&id=50181</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12278">https://phabricator.kde.org/D12278</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kcms/colors/CMakeLists.txt<br />
kcms/colors/Messages.sh<br />
kcms/colors/TODO<br />
kcms/colors/colors.cpp<br />
kcms/colors/colors.desktop<br />
kcms/colors/colors.h<br />
kcms/colors/colorscm.cpp<br />
kcms/colors/colorscm.h<br />
kcms/colors/colorsettings.ui<br />
kcms/colors/editor/CMakeLists.txt<br />
kcms/colors/editor/colorsettings.ui<br />
kcms/colors/editor/kcolorschemeeditor.cpp<br />
kcms/colors/editor/org.kde.kcolorschemeeditor.desktop<br />
kcms/colors/editor/preview.ui<br />
kcms/colors/editor/previewwidget.cpp<br />
kcms/colors/editor/previewwidget.h<br />
kcms/colors/editor/scmeditorcolors.cpp<br />
kcms/colors/editor/scmeditorcolors.h<br />
kcms/colors/editor/scmeditorcolors.ui<br />
kcms/colors/editor/scmeditordialog.cpp<br />
kcms/colors/editor/scmeditordialog.h<br />
kcms/colors/editor/scmeditordialog.ui<br />
kcms/colors/editor/scmeditoreffects.cpp<br />
kcms/colors/editor/scmeditoreffects.h<br />
kcms/colors/editor/scmeditoreffects.ui<br />
kcms/colors/editor/scmeditoroptions.cpp<br />
kcms/colors/editor/scmeditoroptions.h<br />
kcms/colors/editor/scmeditoroptions.ui<br />
kcms/colors/editor/setpreview.ui<br />
kcms/colors/editor/setpreviewwidget.cpp<br />
kcms/colors/editor/setpreviewwidget.h<br />
kcms/colors/kcm_colors.desktop<br />
kcms/colors/kcolorschemeeditor.cpp<br />
kcms/colors/org.kde.kcolorschemeeditor.desktop<br />
kcms/colors/package/contents/ui/main.qml<br />
kcms/colors/package/metadata.desktop<br />
kcms/colors/preview.ui<br />
kcms/colors/previewwidget.cpp<br />
kcms/colors/previewwidget.h<br />
kcms/colors/scmeditorcolors.cpp<br />
kcms/colors/scmeditorcolors.h<br />
kcms/colors/scmeditorcolors.ui<br />
kcms/colors/scmeditordialog.cpp<br />
kcms/colors/scmeditordialog.h<br />
kcms/colors/scmeditordialog.ui<br />
kcms/colors/scmeditoreffects.cpp<br />
kcms/colors/scmeditoreffects.h<br />
kcms/colors/scmeditoreffects.ui<br />
kcms/colors/scmeditoroptions.cpp<br />
kcms/colors/scmeditoroptions.h<br />
kcms/colors/scmeditoroptions.ui<br />
kcms/colors/setpreview.ui<br />
kcms/colors/setpreviewwidget.cpp<br />
kcms/colors/setpreviewwidget.h</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, VDG<br /><strong>Cc: </strong>GB_2, nicolasfella, mart, abetts, ngraham, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol<br /></div>