<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson added a reviewer: Plasma.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />davidedmundson requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18287">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>We can't assume where breeze color files are installed.</p>
<p>If this was a user facing app we should use XDG_DATA_DIRS but as this is<br />
purely used as an install script it should use the data configured in<br />
the found breeze.</p>
<p>There's still a tonne of hardcoded strings in the scripts, but at least<br />
they're now in paths we don't hit.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Now builds on my machine.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R98 Breeze for Gtk</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18287">https://phabricator.kde.org/D18287</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/CMakeLists.txt<br />
src/build_theme.sh<br />
src/render_assets.py</div></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>