<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18239">View Revision</a></tr></table><br /><div><div><p>I'm not sold on this for multiple reasons:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">It's very close to 5.15; I don't thing we should be making consequential UI changes to a controversial component three days before tagging.</li>
<li class="remarkup-list-item">Due to limitations of the current design, this will just exchange one problem (people can't see the pretty login screen wallpaper) for others (people get confused by the lack of a visible UI; people get frustrated by the UI disappearing before they've made a choice, etc.)</li>
<li class="remarkup-list-item">I'm not sure the "no controls are visible before user interaction" UI makes sense for a login screen. I tolerated it for the lock screen because there's only ever one user there, so immediately typing the password is a learnable habit, but the login screen incorporates a user switcher and there are more interactive possibilities. Furthermore, having there be basically no UI visible after you start up your computer just doesn't seem user-friendly to me. Sure, over time, people would get used to it, but is is really an improvement? I don't think so. GNOME has this type of design for their login screen and I find it really unfriendly and annoying there.</li>
</ol>
<p><a href="https://phabricator.kde.org/tag/vdg/" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">#VDG</a>'s opinions these days are that the basic design needs to be looked at in the 5.16 timeframe, because with the current design we have no room to maneuver: every time we change one thing it regresses something else. That's a sign that the design isn't accommodating our needs anymore. See <a href="https://phabricator.kde.org/T10325" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">T10325: 5.16 Login screen redesign</a></p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18239#inline-100714">View Inline</a><span style="color: #4b4d51; font-weight: bold;">config.qml:4</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">property</span> <span style="color: #004012">string</span> <span style="color: #aa4000">type:</span> <span style="color: #766510">"<span class="bright">color</span>"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">property</span> <span style="color: #004012">string</span> <span style="color: #aa4000">type:</span> <span style="color: #766510">"<span class="bright">image</span>"</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">property</span> <span style="color: #004012">color</span> <span style="color: #aa4000">color:</span> <span style="color: #766510">"#1d99f3"</span> <span style="color: #74777d">// Plasma blue</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Seems unrelated?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18239">https://phabricator.kde.org/D18239</a></div></div><br /><div><strong>To: </strong>mart, Plasma, VDG, ngraham<br /><strong>Cc: </strong>ngraham, davidedmundson, plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>