<table><tr><td style="">Zren added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18019">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p><a href="https://phabricator.kde.org/D18155" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D18155</a></p></blockquote>
<p>Looking at the alternative patch, I've renamed the config key variable to <tt style="background: #ebebeb; font-size: 13px;">customDateFormat</tt>. Most of the differences stem from not using a "variant" data type for <tt style="background: #ebebeb; font-size: 13px;">DigitalClock.qml</tt>'s <tt style="background: #ebebeb; font-size: 13px;">dateFormat</tt> variable. The <tt style="background: #ebebeb; font-size: 13px;">string formatDate(datetime date, variant format)</tt> (<a href="http://doc.qt.io/qt-5/qml-qtqml-qt.html#formatDate-method" class="remarkup-link" target="_blank" rel="noreferrer">qt doc link</a>) accepts a variant type.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D18019#390579" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D18019#390579</a>, <a href="https://phabricator.kde.org/p/davidedmundson/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>So for those reasons, I'm inclined to say +1.</p></div>
</blockquote>
<p>Assuming there's no objection to this, I'll merge this Sunday night. The beta is Thurs, so I assume that's the cutoff date?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I don't think the answers to the same question apply to the "First Day of the Week" patch.</p></blockquote>
<p>Fair enough. With that setting, the user sort of expects every date selection calendar popup (Qt/Gtk) to follow that setting. Where as with this setting, the user's expectation is that it should only change the panel's clock widget.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I don't think we need the colour formatting link. It's a niche within a niche. Removing it "solves" the escaping issue as it means the user is doing something undocumented in the first place.</p></blockquote>
<p>Sounds good. Until there's an embedded list of examples (<a href="https://phabricator.kde.org/D18168" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D18168</a>) it could just overwhelm the user with 2 different syntaxes.</p>
<hr class="remarkup-hr" />
<p>Final note. We're using <tt style="background: #ebebeb; font-size: 13px;">Qt.formatDate()</tt>, which means the "time formats" <tt style="background: #ebebeb; font-size: 13px;">hh</tt>, <tt style="background: #ebebeb; font-size: 13px;">mm</tt>, <tt style="background: #ebebeb; font-size: 13px;">ss</tt>, <tt style="background: #ebebeb; font-size: 13px;">t</tt> (time zone), and <tt style="background: #ebebeb; font-size: 13px;">zzz</tt> (millis) are not replaced with their value. Implementing that would require duplicating the "sizehelper timeMetrics" code for the date format though, which I can't guarantee a bugless patch this soon before the 5.15 Beta. If I finish <a href="https://phabricator.kde.org/D18168" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D18168</a>, then it might help suggest to the user that only the "date variables" are accepted.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18019">https://phabricator.kde.org/D18019</a></div></div><br /><div><strong>To: </strong>Zren, Plasma, VDG<br /><strong>Cc: </strong>karpenyamichael, davidedmundson, abetts, cfeck, ngraham, mart, ndavis, rooty, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol<br /></div>