<table><tr><td style="">jgrulich added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17834">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17834#inline-99064">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fortisslvpnauth.cpp:44</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">Setting</span><span style="color: #aa2211">::</span><span class="n">SecretFlags</span> <span class="n">otpFlag</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">Setting</span><span style="color: #aa2211">::</span><span class="n">SecretFlags</span><span style="color: #aa2211">></span><span class="p">(</span><span class="n">data</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">NM_FORTISSLVPN_KEY_OTP</span><span style="color: #766510">"-flags"</span><span class="p">).</span><span class="n">toInt</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">otpFlag</span> <span style="color: #aa2211">==</span> <span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">Setting</span><span style="color: #aa2211">::</span><span class="n">NotSaved</span><span class="p">){</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">ui</span><span class="p">.</span><span class="n">otpFrame</span><span style="color: #aa2211">-></span><span class="n">setVisible</span><span class="p">(</span><span style="color: #304a96">true</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Missing space before "{".</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17834#inline-99062">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fortisslvpnauth.cpp:47</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">ui</span><span class="p">.</span><span class="n">otpFrame</span><span style="color: #aa2211">-></span><span class="n">setVisible</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You can make this shorter:<br />
d->ui.otpFrame->setVisible(otpFlag == NetworkManager::Setting::NotSaved)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17834#inline-99065">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fortisslvpnauth.cpp:69</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">data</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">NM_FORTISSLVPN_KEY_OTP</span><span style="color: #766510">"-flags"</span><span class="p">).</span><span class="n">isEmpty</span><span class="p">()){</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">Setting</span><span style="color: #aa2211">::</span><span class="n">SecretFlags</span> <span class="n">otpFlag</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">Setting</span><span style="color: #aa2211">::</span><span class="n">SecretFlags</span><span style="color: #aa2211">></span><span class="p">(</span><span class="n">data</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">NM_FORTISSLVPN_KEY_OTP</span><span style="color: #766510">"-flags"</span><span class="p">).</span><span class="n">toInt</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Missing space before "{".</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17834#inline-99066">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fortisslvpnauth.cpp:71</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">Setting</span><span style="color: #aa2211">::</span><span class="n">SecretFlags</span> <span class="n">otpFlag</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">Setting</span><span style="color: #aa2211">::</span><span class="n">SecretFlags</span><span style="color: #aa2211">></span><span class="p">(</span><span class="n">data</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">NM_FORTISSLVPN_KEY_OTP</span><span style="color: #766510">"-flags"</span><span class="p">).</span><span class="n">toInt</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">otpFlag</span> <span style="color: #aa2211">==</span> <span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">Setting</span><span style="color: #aa2211">::</span><span class="n">NotSaved</span> <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">ui</span><span class="p">.</span><span class="n">otp</span><span style="color: #aa2211">-></span><span class="n">text</span><span class="p">().</span><span class="n">isEmpty</span><span class="p">()){</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">secrets</span><span class="p">.</span><span class="n">insert</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span class="n">NM_FORTISSLVPN_KEY_OTP</span><span class="p">),</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">ui</span><span class="p">.</span><span class="n">otp</span><span style="color: #aa2211">-></span><span class="n">text</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Missing space before "{".</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17834#inline-99063">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fortisslvpnauth.cpp:72</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">otpFlag</span> <span style="color: #aa2211">==</span> <span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">Setting</span><span style="color: #aa2211">::</span><span class="n">NotSaved</span> <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">ui</span><span class="p">.</span><span class="n">otp</span><span style="color: #aa2211">-></span><span class="n">text</span><span class="p">().</span><span class="n">isEmpty</span><span class="p">()){</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">secrets</span><span class="p">.</span><span class="n">insert</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span class="n">NM_FORTISSLVPN_KEY_OTP</span><span class="p">),</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">ui</span><span class="p">.</span><span class="n">otp</span><span style="color: #aa2211">-></span><span class="n">text</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Missing space after second parameter.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17834#inline-99067">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fortisslvpnwidget.cpp:131</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">data</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">NM_FORTISSLVPN_KEY_OTP</span><span style="color: #766510">"-flags"</span><span class="p">).</span><span class="n">isEmpty</span><span class="p">()){</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">Setting</span><span style="color: #aa2211">::</span><span class="n">SecretFlags</span> <span class="n">otpFlag</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">Setting</span><span style="color: #aa2211">::</span><span class="n">SecretFlags</span><span style="color: #aa2211">></span><span class="p">(</span><span class="n">data</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">NM_FORTISSLVPN_KEY_OTP</span><span style="color: #766510">"-flags"</span><span class="p">).</span><span class="n">toInt</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Missing space before "{".</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17834#inline-99068">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fortisslvpnwidget.cpp:133</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">Setting</span><span style="color: #aa2211">::</span><span class="n">SecretFlags</span> <span class="n">otpFlag</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">Setting</span><span style="color: #aa2211">::</span><span class="n">SecretFlags</span><span style="color: #aa2211">></span><span class="p">(</span><span class="n">data</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">NM_FORTISSLVPN_KEY_OTP</span><span style="color: #766510">"-flags"</span><span class="p">).</span><span class="n">toInt</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">otpFlag</span> <span style="color: #aa2211">&</span> <span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">Setting</span><span style="color: #aa2211">::</span><span class="n">NotSaved</span><span class="p">){</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">advUi</span><span class="p">.</span><span class="n">otp</span><span style="color: #aa2211">-></span><span class="n">setChecked</span><span class="p">(</span><span style="color: #304a96">true</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Missing space before "{".</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17834#inline-99069">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fortisslvpnwidget.cpp:201</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">NMStringMap</span> <span class="n">prevData</span> <span style="color: #aa2211">=</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">setting</span><span style="color: #aa2211">-></span><span class="n">data</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">prevData</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">NM_FORTISSLVPN_KEY_OTP</span><span style="color: #766510">"-flags"</span><span class="p">).</span><span class="n">isEmpty</span><span class="p">()){</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">Setting</span><span style="color: #aa2211">::</span><span class="n">SecretFlags</span> <span class="n">otpFlag</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">Setting</span><span style="color: #aa2211">::</span><span class="n">SecretFlags</span><span style="color: #aa2211">></span><span class="p">(</span><span class="n">data</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">NM_FORTISSLVPN_KEY_OTP</span><span style="color: #766510">"-flags"</span><span class="p">).</span><span class="n">toInt</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Missing space before "{".</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17834#inline-99070">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fortisslvpnwidget.cpp:201</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">NMStringMap</span> <span class="n">prevData</span> <span style="color: #aa2211">=</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">setting</span><span style="color: #aa2211">-></span><span class="n">data</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">prevData</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">NM_FORTISSLVPN_KEY_OTP</span><span style="color: #766510">"-flags"</span><span class="p">).</span><span class="n">isEmpty</span><span class="p">()){</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">Setting</span><span style="color: #aa2211">::</span><span class="n">SecretFlags</span> <span class="n">otpFlag</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">Setting</span><span style="color: #aa2211">::</span><span class="n">SecretFlags</span><span style="color: #aa2211">></span><span class="p">(</span><span class="n">data</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">NM_FORTISSLVPN_KEY_OTP</span><span style="color: #766510">"-flags"</span><span class="p">).</span><span class="n">toInt</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't understand why you hare check for prevData.value(), but later on you get optFlag from data (not prevData). Still I don't think this is needed at all. I would go back and use your previous approach, because the result will be the same.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R116 Plasma Network Management Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17834">https://phabricator.kde.org/D17834</a></div></div><br /><div><strong>To: </strong>enriquem, jgrulich<br /><strong>Cc: </strong>plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>