<table><tr><td style="">davidedmundson requested changes to this revision.<br />davidedmundson added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17321">View Revision</a></tr></table><br /><div><div><p>If Nate and Andy say to use this icon, go for it.</p>

<p>One code change</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17321#inline-96517">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:58</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">imagePath:</span> <span style="color: #766510">"widgets/configuration-icons"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #aa4000">onRepaintNeeded:</span> <span style="color: #004012">toolBoxIcon</span><span class="p">.</span><span style="color: #004012">elementId</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #004012"><span class="bright">iconSvg</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">hasElement</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"menu"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"menu"</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span style="color: #766510">"configure"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">onRepaintNeeded:</span> <span style="color: #004012">toolBoxIcon</span><span class="p">.</span><span style="color: #004012">elementId</span> <span style="color: #aa2211">=</span> <span style="color: #766510">"configure"</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This doesn't make sense..</p>

<p style="padding: 0; margin: 8px;">We're re-evaulating because hasElement might have changed when switching themes.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17321">https://phabricator.kde.org/D17321</a></div></div><br /><div><strong>To: </strong>GB_2, Plasma, VDG, ngraham, davidedmundson<br /><strong>Cc: </strong>davidedmundson, abetts, ngraham, VDG, plasma-devel, Plasma, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, sebas, apol, mbohlender, mart<br /></div>