<table><tr><td style="">broulik updated this revision to Diff 46536.<br />broulik retitled this revision from "Delay finishing download when state changes to "interrupted"" to "Only cancel job when an "error" is set and ignore "interrupted"".<br />broulik edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-hwd2aaoxzxvixnb/">(Show Details)</a><br />broulik edited the test plan for this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-rxe2thutwg5j53d/">(Show Details)</a>
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17233">View Revision</a></tr></table><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>Previously, we would finish the job as soon as it was interrupted leading to a "unknown error" any time a download aborted (even if explicitly canceled by the user).<br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">This patch remembers both state and</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">According to documentation the "error" is set in case of an</span> error<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> and then delays finishing</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">, so we'll want to cancel</span> the <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">download slightly</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">job in this case</span>.<div style="padding: 8px 0;">...</div></div></div></div><br /><div><strong>CHANGES TO TEST PLAN</strong><div><div style="white-space: pre-wrap; color: #74777D;">* Started a download in Firefox, canceled it, no longer got an "unknown error" notification<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">, finish and retry still works</span><br />
* Still works in Chrome</div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R856 Plasma Browser Integration</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D17233?vs=46474&id=46536">https://phabricator.kde.org/D17233?vs=46474&id=46536</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17233">https://phabricator.kde.org/D17233</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>host/downloadjob.cpp</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, davidedmundson, fvogt<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>