<table><tr><td style="">ohelin added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16365">View Revision</a></tr></table><br /><div><div><p>Ok, I just dissected the thing. First, I made the updated diff file against the newest master: <strong>diff_updated.diff</strong>.<br />
Then I saved these files from Phabricator:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item"><strong>Breeze-dark-gtk_gtk-3.20_gtk.css</strong>: saved the left raw diff file</li>
<li class="remarkup-list-item"><strong>Breeze-gtk_gtk-3.20_common.css</strong>: saved the new raw diff file</li>
<li class="remarkup-list-item"><strong>Breeze-gtk_gtk-3.20_gtk.css</strong>: saved the left raw diff file</li>
</ul>
<p>I then made the following diff files:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">diff Breeze-gtk_gtk-3.20_gtk.css Breeze-gtk_gtk-3.20_common.css > diff_gtk_vs_common.diff
diff -t -y --suppress-common-lines Breeze-dark-gtk_gtk-3.20_gtk.css Breeze-gtk_gtk-3.20_common.css > diff_gtk_dark_vs_common.diff</pre></div>
<p>The contents of <strong>diff_gtk_vs_common.diff</strong> are trivial:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">1,3d0
< @define-color headerbar_disabled_highlight_top @disabled_highlight_top;
< @define-color headerbar_disabled_highlight_bottom @disabled_highlight_bottom;
< @define-color headerbar_action_disabled_backdrop @action_disabled_backdrop;</pre></div>
<p>Therefore, <strong>for the light theme, I say the patch is reviewed</strong>. The only new line in the light CSS file imports the new common file, so basically the contents have just been moved.</p>
<p>For the dark theme, we review the file <strong>diff_gtk_dark_vs_common.diff</strong>. Almost all the file is just the obvious, i.e. replacing color literals with the new variables. The real differences start from line 595: border-width has been modified. The differences continue until line 648. In the original files these lines correspond to the following:<br />
Breeze-dark-gtk_gtk-3.20_gtk.css: 3069-3160<br />
Breeze-gtk_gtk-3.20_common.css: 3066-3142</p>
<p>I stripped those lines as files <strong>Breeze-dark-gtk_gtk-3.20_gtk.css_diff_part</strong> and <strong>Breeze-gtk_gtk-3.20_common.css_diff_part</strong>. I then created the special diff which is the beef of this review:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">diff Breeze-dark-gtk_gtk-3.20_gtk.css_diff_part Breeze-gtk_gtk-3.20_common.css_diff_part > special_diff.diff</pre></div>
<p>So, <strong>the only thing left to review is the contents of special_diff.diff</strong>, and obviously that everything looks about correct visually in practice (i.e. the colors are fine). I'll continue to check out that special diff a bit later.</p>
<p><a href="https://phabricator.kde.org/F6342214" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6342214: diff_updated.diff</a><br />
<a href="https://phabricator.kde.org/F6342215" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6342215: Breeze-dark-gtk_gtk-3.20_gtk.css</a><br />
<a href="https://phabricator.kde.org/F6342216" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6342216: Breeze-gtk_gtk-3.20_common.css</a><br />
<a href="https://phabricator.kde.org/F6342218" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6342218: Breeze-gtk_gtk-3.20_gtk.css</a><br />
<a href="https://phabricator.kde.org/F6342220" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6342220: diff_gtk_vs_common.diff</a><br />
<a href="https://phabricator.kde.org/F6342221" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6342221: diff_gtk_dark_vs_common.diff</a><br />
<a href="https://phabricator.kde.org/F6342222" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6342222: Breeze-dark-gtk_gtk-3.20_gtk.css_diff_part</a><br />
<a href="https://phabricator.kde.org/F6342223" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6342223: Breeze-gtk_gtk-3.20_common.css_diff_part</a><br />
<a href="https://phabricator.kde.org/F6342224" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6342224: special_diff.diff</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R98 Breeze for Gtk</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16365">https://phabricator.kde.org/D16365</a></div></div><br /><div><strong>To: </strong>ohelin<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>