<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham added a comment.<br />This revision now requires changes to proceed.<br />Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7849">View Revision</a></tr></table><br /><div><div><p>This does not actually compile for me against current git master:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">/home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp: In static member function ‘static int Units::roundToIconSize(int)’:
/home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp:160:65: error: cannot call member function ‘int Units::devicePixelIconSize(int) const’ without object
     } else if (size < devicePixelIconSize(KIconLoader::SizeSmall)) {
                                                                 ^
/home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp:161:58: error: cannot call member function ‘int Units::devicePixelIconSize(int) const’ without object
         return devicePixelIconSize(KIconLoader::SizeSmall) / 2;
                                                          ^
/home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp:162:71: error: cannot call member function ‘int Units::devicePixelIconSize(int) const’ without object
     } else if (size < devicePixelIconSize(KIconLoader::SizeSmallMedium)) {
                                                                       ^
/home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp:163:58: error: cannot call member function ‘int Units::devicePixelIconSize(int) const’ without object
         return devicePixelIconSize(KIconLoader::SizeSmall);
                                                          ^
/home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp:164:66: error: cannot call member function ‘int Units::devicePixelIconSize(int) const’ without object
     } else if (size < devicePixelIconSize(KIconLoader::SizeMedium)) {
                                                                  ^
/home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp:165:64: error: cannot call member function ‘int Units::devicePixelIconSize(int) const’ without object
         return devicePixelIconSize(KIconLoader::SizeSmallMedium);
                                                                ^
/home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp:166:65: error: cannot call member function ‘int Units::devicePixelIconSize(int) const’ without object
     } else if (size < devicePixelIconSize(KIconLoader::SizeLarge)) {
                                                                 ^
/home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp:167:59: error: cannot call member function ‘int Units::devicePixelIconSize(int) const’ without object
         return devicePixelIconSize(KIconLoader::SizeMedium);
                                                           ^
/home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp:168:64: error: cannot call member function ‘int Units::devicePixelIconSize(int) const’ without object
     } else if (size < devicePixelIconSize(KIconLoader::SizeHuge)) {
                                                                ^
/home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp:169:58: error: cannot call member function ‘int Units::devicePixelIconSize(int) const’ without object
         return devicePixelIconSize(KIconLoader::SizeLarge);
                                                          ^
src/plasmaquick/CMakeFiles/KF5PlasmaQuick.dir/build.make:374: recipe for target 'src/plasmaquick/CMakeFiles/KF5PlasmaQuick.dir/__/declarativeimports/core/units.cpp.o' failed
make[2]: *** [src/plasmaquick/CMakeFiles/KF5PlasmaQuick.dir/__/declarativeimports/core/units.cpp.o] Error 1
CMakeFiles/Makefile2:1782: recipe for target 'src/plasmaquick/CMakeFiles/KF5PlasmaQuick.dir/all' failed
make[1]: *** [src/plasmaquick/CMakeFiles/KF5PlasmaQuick.dir/all] Error 2</pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7849">https://phabricator.kde.org/D7849</a></div></div><br /><div><strong>To: </strong>pgkos, Plasma, ngraham<br /><strong>Cc: </strong>kde-frameworks-devel, aspotashev, ngraham, anthonyfieroni, broulik, davidedmundson, plasma-devel, ragreen, Pitel, michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, Frameworks<br /></div>