<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16257">View Revision</a></tr></table><br /><div><div><p>Actually, the original wording is correct--or at least more correct.</p>
<p>"popup" is a noun, something that can be closed, so "Close popup" is fine. "Close Pop Up" is not correct, because "Pop Up" is a verb construction: "Pop up that thing, will ya?"</p>
<p>The only thing that we could maybe do here is change "popup" to "pop-up", but we would want to first decide on a standardized form, codify it in the HIG (<a href="http://hig.kde.org/" class="remarkup-link" target="_blank" rel="noreferrer">http://hig.kde.org/</a>), and then change it everywhere, not just here.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16257">https://phabricator.kde.org/D16257</a></div></div><br /><div><strong>To: </strong>shubham, Plasma, ngraham<br /><strong>Cc: </strong>ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>