<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15744">View Revision</a></tr></table><br /><div><div><p>Thanks for look, Will update based on feedback later today.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15744#inline-85076">View Inline</a><span style="color: #4b4d51; font-weight: bold;">broulik</span> wrote in <span style="color: #4b4d51; font-weight: bold;">ForecastView.qml:38</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">Layout.preferredWidth</tt> defaults to <tt style="background: #ebebeb; font-size: 13px;">implicitWidth</tt>, see [1] on the "preference order"</p>
<p style="padding: 0; margin: 8px;">[1] <a href="https://doc.qt.io/qt-5/qtquicklayouts-overview.html#specifying-preferred-size" class="remarkup-link" target="_blank" rel="noreferrer">https://doc.qt.io/qt-5/qtquicklayouts-overview.html#specifying-preferred-size</a></p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I did this code to spare some `if Layout && Layout.preferredWidth && Layout.preferredWidth > 0 { use Layout.preferredWidth } else { else use implicitWidth) in the calculation, seems that was not obvious outside my brain :)<br />
Guess I should then not do that optimization, no big loss, will change.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15744#inline-85075">View Inline</a><span style="color: #4b4d51; font-weight: bold;">broulik</span> wrote in <span style="color: #4b4d51; font-weight: bold;">ForecastView.qml:119</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">You can just do <tt style="background: #ebebeb; font-size: 13px;">children[i].Layout.preferredWidth</tt>, no need for a "proxy" property</p>
<p style="padding: 0; margin: 8px;">Also, shouldn't it rather be</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">for (var i = 0; i < repeater.count; ++i) {
var child = repeater.itemAt(i);
...
}</pre></div>
<p style="padding: 0; margin: 8px;">Also I *think* that should auto-propagate, no?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Had not yet tried to look at repeater childs, let me try that.</p>
<p style="padding: 0; margin: 8px;">At least from what I remember about testing any auto-propagation from repeater & loader, this did not work as expected, so I turned to do all explicitly. Though not exactly sure what you mean with "that"?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15744">https://phabricator.kde.org/D15744</a></div></div><br /><div><strong>To: </strong>kossebau, broulik<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>