<table><tr><td style="">pino requested changes to this revision.<br />pino added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15440">View Revision</a></tr></table><br /><div><div><p>NACK, this is not the correct approach.<br />
The right approach is translate the messages via the .po file that contains them: <a href="https://websvn.kde.org/trunk/l10n-kf5/ru/messages/kde-workspace/plasma-browser-extension.po?view=markup" class="remarkup-link" target="_blank" rel="noreferrer">https://websvn.kde.org/trunk/l10n-kf5/ru/messages/kde-workspace/plasma-browser-extension.po?view=markup</a> (and the same in <tt style="background: #ebebeb; font-size: 13px;">branches/stable/l10n-kf5</tt>). There is an automatic system that extracts the messages into plasma-browser-extension.pot, and injects all the translations back to the repository in form of <tt style="background: #ebebeb; font-size: 13px;">messages.json</tt> files.</p>
<p>For more information, please contact the Russian translation team: <a href="https://l10n.kde.org/team-infos.php?teamcode=ru" class="remarkup-link" target="_blank" rel="noreferrer">https://l10n.kde.org/team-infos.php?teamcode=ru</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R856 Plasma Browser Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15440">https://phabricator.kde.org/D15440</a></div></div><br /><div><strong>To: </strong>sheykhnurlatipov, pino<br /><strong>Cc: </strong>pino, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>