<table><tr><td style="">hein updated this revision to Diff 41354.<br />hein edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-yiyaxjqhnecccpc/">(Show Details)</a><br />hein added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15410">View Revision</a></tr></table><br /><div><div><p>Improve description further.</p></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>when a new window enters the source model stack. <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">That</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">This</span> meant the<div style="padding: 8px 0;">...</div>occur at any time, and things should<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">n'</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> not jus</span>t move around on<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> the user</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">the user </span>- this sort mode is called "Manual" for a reason. Also,<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> the</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">the </span>visual result would still be poor: The window would initially<br />
appear at the wrong position, then move <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">in</span>to the right one a<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> bit</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">short moment </span>later.<div style="padding: 8px 0;">...</div> the tasks is initially hidden.<span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br />
* The sort code skips over hidden window tasks in the sort</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">* It skips over hidden tasks in</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"> insert queue instead of moving</span> the<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"> sort insert</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">m. The</span> queue i<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">nstead</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">s marked as</span><br />
<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">of mov</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">stale then, and cleared on unrelated window</span>ing <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">them</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">system changes</span>.<div style="padding: 8px 0;">...</div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D15410?vs=41353&id=41354">https://phabricator.kde.org/D15410?vs=41353&id=41354</a></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15410">https://phabricator.kde.org/D15410</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>libtaskmanager/taskmanagerrulesrc<br />
libtaskmanager/tasksmodel.cpp<br />
libtaskmanager/tasktools.cpp<br />
libtaskmanager/tasktools.h<br />
libtaskmanager/waylandtasksmodel.cpp<br />
libtaskmanager/xwindowtasksmodel.cpp</div></div></div><br /><div><strong>To: </strong>hein, davidedmundson, broulik<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>