<table><tr><td style="">pino added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15093">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D15093#319336" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D15093#319336</a>, <a href="https://phabricator.kde.org/p/andersonbruce/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@andersonbruce</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>If you as a representative of the plasma-nm philosophy have a preference on which way to go or have a brilliant idea which solves all the problems, I will follow your lead.</p></div>
</blockquote>
<p>I'm not a plasma-nm developer, <a href="https://phabricator.kde.org/p/jgrulich/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@jgrulich</a> is :)<br />
Your explanation makes sense, thanks for taking the time to explain it. One thing I (don't) see is the configuration of pre/post scripts in plasma-nm for other types of connections (I can only check for wired, wireless, and openvpn). Maybe a possible idea is to leave them out for the first version, and implement them later if a) deemed appropriate for plasma-nm users b) solved their configuration mess as you described it.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15093#inline-81749">View Inline</a><span style="color: #4b4d51; font-weight: bold;">andersonbruce</span> wrote in <span style="color: #4b4d51; font-weight: bold;">wireguard.cpp:175-178</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">The problem with using the KConfig method is if a space slips into the config file before or after the comma then the spaces are left in one or the other of the QStrings and I have to process each entry in the list to remove the spaces. The files can come from elsewhere, e.g. I have some provided by my VPN which have spaces in comma separated lists. Using split allows both operations to be performed at the same time.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is what <tt style="background: #ebebeb; font-size: 13px;">QString::trimmed()</tt> does already. Considering you are passing the string directly to QHostAddress, it is just easy to write</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="c++" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">const</span> <span class="n">QPair</span><span style="color: #aa2211"><</span><span class="n">QHostAddress</span><span class="p">,</span> <span style="color: #aa4000">int</span><span style="color: #aa2211">></span> <span class="n">addressIn</span> <span style="color: #aa2211">=</span> <span class="n">QHostAddress</span><span style="color: #aa2211">::</span><span class="n">parseSubnet</span><span class="p">(</span><span class="n">addressList</span><span class="p">[</span><span class="n">i</span><span class="p">].</span><span class="n">trimmed</span><span class="p">());</span></pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R116 Plasma Network Management Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15093">https://phabricator.kde.org/D15093</a></div></div><br /><div><strong>To: </strong>andersonbruce, Plasma, jgrulich, pino<br /><strong>Cc: </strong>acrouthamel, K900, anthonyfieroni, pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>