<table><tr><td style="">pino requested changes to this revision.<br />pino added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15093">View Revision</a></tr></table><br /><div><div><p>Misc notes:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">please remove all the translations (i.e. <tt style="background: #ebebeb; font-size: 13px;">Name=[lang]</tt> & <tt style="background: #ebebeb; font-size: 13px;">Comment[lang]</tt> from desktop/json files, since KDE has an automatic system to handle them</li>
<li class="remarkup-list-item">please use <a href="https://api.kde.org/frameworks/kconfig/html/classKConfig.html" class="remarkup-link" target="_blank" rel="noreferrer">KConfig</a> to read & write ini-like files, instead of doing everything manually</li>
<li class="remarkup-list-item">the <tt style="background: #ebebeb; font-size: 13px;">PasswordField</tt> class is already available as <tt style="background: #ebebeb; font-size: 13px;">libs/editor/widgets/passwordfield.h</tt>, part of the <tt style="background: #ebebeb; font-size: 13px;">plasmanm_editor</tt> library, so you do not need to copy it locally</li>
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">wireguard_global.h</tt> seems not used, so just drop it</li>
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">nm-wireguard-service.h</tt> has lots of <tt style="background: #ebebeb; font-size: 13px;">NM_OPENVPN_</tt> keys that are not used</li>
<li class="remarkup-list-item">as <a href="https://phabricator.kde.org/p/lbeltrame/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@lbeltrame</a> said, please use <tt style="background: #ebebeb; font-size: 13px;">QHostAddress</tt> to parse IP addresses</li>
<li class="remarkup-list-item">as <a href="https://phabricator.kde.org/p/lbeltrame/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@lbeltrame</a> said, hardcoding colors is a bad idea, and it will not play nice with user choice of different color schemes, or accessibility purposes</li>
<li class="remarkup-list-item">a better option to validate an input in a line edit is to use the embedded validator options, see <tt style="background: #ebebeb; font-size: 13px;">QLineEdit::setInputMask</tt> and <tt style="background: #ebebeb; font-size: 13px;">QValidator</tt></li>
<li class="remarkup-list-item">the better option to edit a port number is <tt style="background: #ebebeb; font-size: 13px;">QSpinBox</tt> restricted to 0-65536, instead of a line edit</li>
<li class="remarkup-list-item">there is a mixture of <tt style="background: #ebebeb; font-size: 13px;">virtual</tt> & <tt style="background: #ebebeb; font-size: 13px;">Q_DECL_OVERRIDE</tt> for virtual methods; plasma-nm uses <tt style="background: #ebebeb; font-size: 13px;">override</tt> exclusively</li>
<li class="remarkup-list-item">please do not hardcode sizes and fonts in UI files</li>
<li class="remarkup-list-item">there are various texts in UI files with double spaces between words, please simply them to a single space</li>
<li class="remarkup-list-item">manually calling <tt style="background: #ebebeb; font-size: 13px;">KAcceleratorManager::manage(this);</tt> is not needed, why were they added?</li>
</ul></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15093#inline-80807">View Inline</a><span style="color: #4b4d51; font-weight: bold;">plasmanetworkmanagement_wireguardui.desktop:7-8</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">X-NetworkManager-Services=org.freedesktop.NetworkManager.wireguard
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">X-KDE-PluginInfo-Author=Lukáš Tinkl
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">X-KDE-PluginInfo-Email=lukas@kde.org
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">X-KDE-PluginInfo-Name=plasmanetworkmanagement_wireguardui
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Surely this was not done by Lukáš... please fill in your name/email.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15093#inline-80808">View Inline</a><span style="color: #4b4d51; font-weight: bold;">wireguardadvanced.ui:39</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <property name="text">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <string>Intreface</string>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> </property>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">typo, "Interface:"</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R116 Plasma Network Management Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15093">https://phabricator.kde.org/D15093</a></div></div><br /><div><strong>To: </strong>andersonbruce, Plasma, jgrulich, pino<br /><strong>Cc: </strong>pino, lbeltrame, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>