<table><tr><td style="">ngraham added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14855">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14855#inline-79835">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:44</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">// does this need an ellipsis?</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #004012">readonly</span> <span style="color: #004012">property</span> <span style="color: #004012">string</span> <span style="color: #aa4000">kcmLabel:</span> <span style="color: #004012">i18nc</span><span class="p">(</span><span style="color: #766510">"Open the full display settings module"</span><span class="p">,</span> <span style="color: #766510">"Advanced Display Settings..."</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #004012">readonly</span> <span style="color: #004012">property</span> <span style="color: #004012">string</span> <span style="color: #aa4000">kcmIconName:</span> <span style="color: #766510">"preferences-desktop-display-randr"</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Per <a href="https://hig.kde.org/style/writing/labels.html#using-ellipses-in-labels" class="remarkup-link" target="_blank" rel="noreferrer">https://hig.kde.org/style/writing/labels.html#using-ellipses-in-labels</a>, if you want this to have ellipses, it has to start with an action verb (e.g. "Configure blabla..."). If not, it shouldn't have ellipses, because it's not an action, it's for navigation.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R104 KScreen</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14855">https://phabricator.kde.org/D14855</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, VDG, fischbach, harmathy<br /><strong>Cc: </strong>ngraham, mart, gladhorn, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol<br /></div>