<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14857">View Revision</a></tr></table><br /><div><div><p>Thanks for your patch and explanation on the mailing list!</p>

<p>The idea was mostly to show "which file it is currently copying" but I can see there are more cases where the source is weird than to where the destination is wrong?<br />
I'll add VDG to get some usability/design feedback on that one.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14857#inline-78816">View Inline</a><span style="color: #4b4d51; font-weight: bold;">JobDelegate.qml:70</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">text:</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                <span style="color: #aa4000">var</span> <span style="color: #004012">label</span> <span style="color: #aa2211">=</span> <span style="color: #004012">labelFileName0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">var</span> <span style="color: #004012">label</span> <span style="color: #aa2211">=</span> <span style="color: #004012">labelFileName<span class="bright">1</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">labelFileName1 :</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">labelFileName</span>0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                <span style="color: #aa4000">var</span> <span style="color: #004012">lastSlashIdx</span> <span style="color: #aa2211">=</span> <span style="color: #004012">label</span><span class="p">.</span><span style="color: #004012">lastIndexOf</span><span class="p">(</span><span style="color: #766510">"/"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Could be simplified to</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">var label = labelFileName1 || labelFileName0;</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14857">https://phabricator.kde.org/D14857</a></div></div><br /><div><strong>To: </strong>karthikp<br /><strong>Cc: </strong>broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>