<table><tr><td style="">lepagevalleeemmanuel created this revision.<br />lepagevalleeemmanuel added a reviewer: mart.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.<br />lepagevalleeemmanuel requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14693">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Add support for static Qt plugins.</p>
<p>This style can now replace the default style in applications built<br />
with the static Qt SDK. It allows better encapsulation on the desktop<br />
and makes it easier to try applications on Plasma Mobile.</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Remove dead code **</li>
</ul>
<p>There was an unused class</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Gnerate a QML QRC at build-time **</li>
</ul>
<p>Since commit <a href="https://phabricator.kde.org/R858:d0e3daafdbdd858a5ee6e6b0b2de6a7a39ff27f1" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">d0e3daafdbd</a>, all QML files are now preprocessed. This<br />
renders the QRC file introduced in a few commits ago invalid since<br />
it uses the non-preprocessed files.</p>
<p>The commit also reorder the CMake targets to make sure the files<br />
are preprecessed before the plugin is built.</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Rename org.kde.qqc2desktopstyle.private to org.kde.desktop.private **</li>
</ul>
<p>Submodules are supposed to have a consistent URI</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Add an option to enable or disable plasma integration. **</li>
</ul>
<p>The way the plugin is built is incompatible with static AppImage and<br />
probably other self contained file format.</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Use the same coding style for all "private" import **</li>
</ul>
<p>First, there was a typo in my previous commit. But the main problem<br />
was that even like that, mixing org.kde.desktop/private,<br />
org.kde.desktop.private and "private" is not very portable when<br />
switching between static and dynamic mode.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Not much. Works for me. It will need other users to validate it didn't regress anything for them. I would suggest not merging this as-is</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R858 Qt Quick Controls 2: Desktop Style</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14693">https://phabricator.kde.org/D14693</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
org.kde.desktop/Button.qml<br />
org.kde.desktop/CheckBox.qml<br />
org.kde.desktop/CheckDelegate.qml<br />
org.kde.desktop/CheckIndicator.qml<br />
org.kde.desktop/ComboBox.qml<br />
org.kde.desktop/Dial.qml<br />
org.kde.desktop/ItemDelegate.qml<br />
org.kde.desktop/Label.qml<br />
org.kde.desktop/ProgressBar.qml<br />
org.kde.desktop/RadioButton.qml<br />
org.kde.desktop/RadioDelegate.qml<br />
org.kde.desktop/ScrollBar.qml<br />
org.kde.desktop/ScrollView.qml<br />
org.kde.desktop/Slider.qml<br />
org.kde.desktop/SpinBox.qml<br />
org.kde.desktop/SwitchDelegate.qml<br />
org.kde.desktop/SwitchIndicator.qml<br />
org.kde.desktop/TabBar.qml<br />
org.kde.desktop/TabButton.qml<br />
org.kde.desktop/TextArea.qml<br />
org.kde.desktop/TextField.qml<br />
org.kde.desktop/ToolButton.qml<br />
org.kde.desktop/private/FocusRect.qml<br />
org.kde.desktop/private/qmldir<br />
org.kde.desktop/qmldir<br />
plugin/CMakeLists.txt<br />
plugin/kquickstyleitem.cpp<br />
plugin/kquickstyleitem_p.h<br />
plugin/qqc2desktopstyleplugin.cpp<br />
style.qrc.in</div></div></div><br /><div><strong>To: </strong>lepagevalleeemmanuel, mart<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>