<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14354">View Revision</a></tr></table><br /><div><div><p>Thanks for the patch, I agree with you that live searching is better usability.</p>
<p>So far though I had stayed away from implementing that, as I have no idea how the weather service providers like their servers getting more hits once in a while .</p>
<p>I would prefer if we could first check the terms of usage of the currently used weather services before implementing this (where needed, IIRC for some there is a static list downloaded).</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14354#inline-75651">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ConfigWeatherStation.qml:72</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">var</span> <span style="color: #004012">config</span> <span style="color: #aa2211">=</span> <span style="color: #004012">plasmoid</span><span class="p">.</span><span style="color: #004012">nativeInterface</span><span class="p">.</span><span style="color: #004012">configValues</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"> </span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">config</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">services</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">length</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">==</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">config</span><span class="p">.</span><span style="color: #004012">services</span> <span style="color: #aa2211">=</span> <span class="p">[</span><span style="color: #766510">'wettercom'</span><span class="p">]</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Defaulting to the private service wetter.com goes against the idea of keeping the user in control of their privacy by default.</p>
<p style="padding: 0; margin: 8px;">I know the current UX sucks, that popup menu is broken by design. But this is not a fix I can support.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14354">https://phabricator.kde.org/D14354</a></div></div><br /><div><strong>To: </strong>underwit, Plasma, kossebau<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>