<table><tr><td style="">zzag added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14264">View Revision</a></tr></table><br /><div><div><p>Probably stupid question, I'm just curious.. Why had only one receiver been changed to <tt style="background: #ebebeb; font-size: 13px;">decoration.data()</tt>? Why that's not the case for</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span class="n">connect</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">DecorationButton</span><span style="color: #aa2211">::</span><span class="n">hoveredChanged</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">updateSlot</span><span class="p">);</span></pre></div>

<p>?</p>

<p>Just for reference</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">void</span> <span class="n">DecorationButton</span><span style="color: #aa2211">::</span><span class="n">update</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QRectF</span> <span style="color: #aa2211">&</span><span class="n">rect</span><span class="p">)</span>
<span class="p">{</span>
    <span class="n">decoration</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">update</span><span class="p">(</span><span class="n">rect</span><span class="p">.</span><span class="n">isNull</span><span class="p">()</span> <span style="color: #aa2211">?</span> <span class="n">geometry</span><span class="p">().</span><span class="n">toRect</span><span class="p">()</span> <span style="color: #aa2211">:</span> <span class="n">rect</span><span class="p">.</span><span class="n">toRect</span><span class="p">());</span>
<span class="p">}</span></pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R129 Window Decoration Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14264">https://phabricator.kde.org/D14264</a></div></div><br /><div><strong>To: </strong>davidedmundson, KWin<br /><strong>Cc: </strong>zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>